linux-kernel - Re: [PATCH] x86: of: Kill unused early_init_dt_scan_chosen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 24 Oct 2021 23:26:58 -0500
From:   Frank Rowand <frowand.list@...il.com>
To:     Rob Herring <robh@...nel.org>, x86@...nel.org
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] x86: of: Kill unused early_init_dt_scan_chosen_arch()

On 10/22/21 11:46 AM, Rob Herring wrote:
> There are no callers for early_init_dt_scan_chosen_arch(), so remove it.
> 
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: x86@...nel.org
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: Frank Rowand <frowand.list@...il.com>
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>  arch/x86/kernel/devicetree.c | 5 -----
>  include/linux/of_fdt.h       | 1 -
>  2 files changed, 6 deletions(-)
> 
> diff --git a/arch/x86/kernel/devicetree.c b/arch/x86/kernel/devicetree.c
> index 3aa1e99df2a9..5cd51f25f446 100644
> --- a/arch/x86/kernel/devicetree.c
> +++ b/arch/x86/kernel/devicetree.c
> @@ -31,11 +31,6 @@ char __initdata cmd_line[COMMAND_LINE_SIZE];
>  
>  int __initdata of_ioapic;
>  
> -void __init early_init_dt_scan_chosen_arch(unsigned long node)
> -{
> -	BUG();
> -}
> -
>  void __init early_init_dt_add_memory_arch(u64 base, u64 size)
>  {
>  	BUG();
> diff --git a/include/linux/of_fdt.h b/include/linux/of_fdt.h
> index cf6a65b94d40..cf48983d3c86 100644
> --- a/include/linux/of_fdt.h
> +++ b/include/linux/of_fdt.h
> @@ -65,7 +65,6 @@ extern int early_init_dt_scan_memory(unsigned long node, const char *uname,
>  extern int early_init_dt_scan_chosen_stdout(void);
>  extern void early_init_fdt_scan_reserved_mem(void);
>  extern void early_init_fdt_reserve_self(void);
> -extern void __init early_init_dt_scan_chosen_arch(unsigned long node);
>  extern void early_init_dt_add_memory_arch(u64 base, u64 size);
>  extern u64 dt_mem_next_cell(int s, const __be32 **cellp);
>  
> 

Reviewed-by: Frank Rowand <frank.rowand@...y.com>