linux-kernel - Re: [PATCH 3/3] refscale: always log the error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f4c53e4-34aa-98f6-343f-0de18df830f2@fujitsu.com>
Date:   Mon, 25 Oct 2021 06:12:40 +0000
From:   "lizhijian@...itsu.com" <lizhijian@...itsu.com>
To:     "lizhijian@...itsu.com" <lizhijian@...itsu.com>,
        "dave@...olabs.net" <dave@...olabs.net>,
        "paulmck@...nel.org" <paulmck@...nel.org>,
        "josh@...htriplett.org" <josh@...htriplett.org>,
        "rostedt@...dmis.org" <rostedt@...dmis.org>,
        "mathieu.desnoyers@...icios.com" <mathieu.desnoyers@...icios.com>,
        "jiangshanlai@...il.com" <jiangshanlai@...il.com>,
        "joel@...lfernandes.org" <joel@...lfernandes.org>,
        "rcu@...r.kernel.org" <rcu@...r.kernel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] refscale: always log the error message



On 25/10/2021 11:26, Li Zhijian wrote:
> Generally, error message should be logged anyhow.
>
> Signed-off-by: Li Zhijian <lizhijian@...fujitsu.com>
> ---
>   kernel/rcu/refscale.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/rcu/refscale.c b/kernel/rcu/refscale.c
> index a4479f00dcdc..f055d168365a 100644
> --- a/kernel/rcu/refscale.c
> +++ b/kernel/rcu/refscale.c
> @@ -58,8 +58,8 @@ do {											\
>   	}										\
>   } while (0)
>   
> -#define VERBOSE_SCALEOUT_ERRSTRING(s, x...) \
> -	do { if (verbose) pr_alert("%s" SCALE_FLAG "!!! " s, scale_type, ## x); } while (0)
> +#define SCALEOUT_ERRSTRING(s, x...) \
> +	do { pr_alert("%s" SCALE_FLAG "!!! " s, scale_type, ## x); } while (0)
>   
>   MODULE_LICENSE("GPL");
>   MODULE_AUTHOR("Joel Fernandes (Google) <joel@...lfernandes.org>");
> @@ -651,7 +651,7 @@ static int main_func(void *arg)
>   	result_avg = kzalloc(nruns * sizeof(*result_avg), GFP_KERNEL);
>   	buf = kzalloc(800 + 64, GFP_KERNEL);
>   	if (!result_avg || !buf) {
> -		VERBOSE_SCALEOUT_ERRSTRING("out of memory");
> +		SCALEOUT_ERRSTRING("out of memory");

'\n' should be added to the last to flush it.



>   		goto oom_exit;
>   	}
>   	if (holdoff)
> @@ -837,7 +837,7 @@ ref_scale_init(void)
>   	reader_tasks = kcalloc(nreaders, sizeof(reader_tasks[0]),
>   			       GFP_KERNEL);
>   	if (!reader_tasks) {
> -		VERBOSE_SCALEOUT_ERRSTRING("out of memory");
> +		SCALEOUT_ERRSTRING("out of memory");
ditto

Thanks
Zhijian
>   		firsterr = -ENOMEM;
>   		goto unwind;
>   	}