linux-kernel - Re: [PATCH 5.10 70/95] gcc-plugins/structleak: add makefile var for disabling structleak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 25 Oct 2021 23:40:59 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Brendan Higgins <brendanhiggins@...gle.com>
Cc:     Pavel Machek <pavel@...x.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Kees Cook <keescook@...omium.org>,
        David Gow <davidgow@...gle.com>,
        Shuah Khan <skhan@...uxfoundation.org>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 5.10 70/95] gcc-plugins/structleak: add makefile var for
 disabling structleak

Hi!

> > > [ Upstream commit 554afc3b9797511e3245864e32aebeb6abbab1e3 ]
> > >
> > > KUnit and structleak don't play nice, so add a makefile variable for
> > > enabling structleak when it complains.
> >
> > AFAICT, this patch does nothing useful in 5.10. Unlike mainline,
> > DISABLE_STRUCTLEAK_PLUGIN is not used elsewhere in the tree.
> 
> The related patches that Greg picked up use this makefile variable.

I don't think so, not in 5.10. Can you double-check?

pavel@duo:~/cip/krc$ grep -ri DISABLE_STRUCTLEAK_PLUGIN .
./scripts/Makefile.gcc-plugins:    DISABLE_STRUCTLEAK_PLUGIN += -fplugin-arg-structleak_plugin-disable
./scripts/Makefile.gcc-plugins:export DISABLE_STRUCTLEAK_PLUGIN
pavel@duo:~/cip/krc$ 
commit b67ee9a213819f2c817e3d344c2fc186f299a4f5 (HEAD, origin/queue/5.10)
Author: Fabien Dessenne <fabien.dessenne@...s.st.com>
Date:   Fri Oct 8 14:25:17 2021 +0200

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)