lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 Oct 2021 12:01:23 +0530 From: Vinod Koul <vkoul@...nel.org> To: Arnd Bergmann <arnd@...nel.org> Cc: Hyun Kwon <hyun.kwon@...inx.com>, Laurent Pinchart <laurent.pinchart@...asonboard.com>, Michal Simek <michal.simek@...inx.com>, Sanjay R Mehta <sanju.mehta@....com>, Peter Ujfalusi <peter.ujfalusi@...com>, Arnd Bergmann <arnd@...db.de>, Jianqiang Chen <jianqiang.chen@...inx.com>, Quanyang Wang <quanyang.wang@...driver.com>, Yang Li <yang.lee@...ux.alibaba.com>, Allen Pais <apais@...ux.microsoft.com>, Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, Biju Das <biju.das.jz@...renesas.com>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, dmaengine@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] dmaengine: remove debugfs #ifdef On 20-09-21, 14:20, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@...db.de> > > The ptdma driver has added debugfs support, but this fails to build > when debugfs is disabled: > > drivers/dma/ptdma/ptdma-debugfs.c: In function 'ptdma_debugfs_setup': > drivers/dma/ptdma/ptdma-debugfs.c:93:54: error: 'struct dma_device' has no member named 'dbg_dev_root' > 93 | debugfs_create_file("info", 0400, pt->dma_dev.dbg_dev_root, pt, > | ^ > drivers/dma/ptdma/ptdma-debugfs.c:96:55: error: 'struct dma_device' has no member named 'dbg_dev_root' > 96 | debugfs_create_file("stats", 0400, pt->dma_dev.dbg_dev_root, pt, > | ^ > drivers/dma/ptdma/ptdma-debugfs.c:102:52: error: 'struct dma_device' has no member named 'dbg_dev_root' > 102 | debugfs_create_dir("q", pt->dma_dev.dbg_dev_root); > | ^ > > Remove the #ifdef in the header, as this only saves a few bytes, > but would require ugly #ifdefs in each driver using it. > Simplify the other user while we're at it. Applied, thanks -- ~Vinod
Powered by blists - more mailing lists