linux-kernel - Re: [PATCH] drm/i915/selftests: Fix inconsistent IS_ERR and PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f0f66cb7-ce70-b968-2fa2-64c39a87e98c@intel.com>
Date:   Mon, 25 Oct 2021 09:01:10 +0100
From:   Matthew Auld <matthew.auld@...el.com>
To:     Kai Song <songkai01@...pur.com>, jani.nikula@...ux.intel.com,
        joonas.lahtinen@...ux.intel.com, rodrigo.vivi@...el.com
Cc:     airlied@...ux.ie, daniel@...ll.ch, jason@...kstrand.net,
        thomas.hellstrom@...ux.intel.com, intel-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/i915/selftests: Fix inconsistent IS_ERR and PTR_ERR

On 22/10/2021 13:06, Kai Song wrote:
> Fix inconsistent IS_ERR and PTR_ERR in i915_gem_dmabuf.c
> 
> Signed-off-by: Kai Song <songkai01@...pur.com>

Pushed to drm-intel-gt-next. Thanks.

> ---
>   drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c
> index 4a6bb64c3a35..3cc74b0fed06 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c
> @@ -102,7 +102,7 @@ static int igt_dmabuf_import_same_driver_lmem(void *arg)
>   	obj = __i915_gem_object_create_user(i915, PAGE_SIZE, &lmem, 1);
>   	if (IS_ERR(obj)) {
>   		pr_err("__i915_gem_object_create_user failed with err=%ld\n",
> -		       PTR_ERR(dmabuf));
> +		       PTR_ERR(obj));
>   		err = PTR_ERR(obj);
>   		goto out_ret;
>   	}
> @@ -158,7 +158,7 @@ static int igt_dmabuf_import_same_driver(struct drm_i915_private *i915,
>   					    regions, num_regions);
>   	if (IS_ERR(obj)) {
>   		pr_err("__i915_gem_object_create_user failed with err=%ld\n",
> -		       PTR_ERR(dmabuf));
> +		       PTR_ERR(obj));
>   		err = PTR_ERR(obj);
>   		goto out_ret;
>   	}
>