linux-kernel - Re: [PATCH v1 1/1] gpio: mlxbf2.c: Add check for bgpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 25 Oct 2021 12:31:23 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Asmaa Mnebhi <asmaa@...dia.com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v1 1/1] gpio: mlxbf2.c: Add check for bgpio_init failure

On Mon, Oct 25, 2021 at 11:15 AM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> On Fri, Oct 22, 2021 at 3:44 PM Asmaa Mnebhi <asmaa@...dia.com> wrote:

A nit-pick that may be ignored...

> >                         NULL,
> >                         0);
> >
> > +       if (ret) {
> > +               dev_err(dev, "bgpio_init failed\n");
> > +               return ret;
> > +       }

> > +

...can we utilize an empty line before if (ret) { instead?

-- 
With Best Regards,
Andy Shevchenko