linux-kernel - Re: [PATCH] staging: rtl8723bs: core: Refactor nested if-else

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 25 Oct 2021 12:02:27 +0200
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>,
        kushal kothari <kushalkothari285@...il.com>
Cc:     fabioaiuto83@...il.com, ross.schm.dev@...il.com,
        hdegoede@...hat.com, marcocesati@...il.com,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        outreachy-kernel@...glegroups.com,
        Mike Rapoport <mike.rapoport@...il.com>,
        kushalkothari2850@...il.com
Subject: Re: [PATCH] staging: rtl8723bs: core: Refactor nested if-else

On Monday, October 25, 2021 9:56:00 AM CEST kushal kothari wrote:
> >Very long line, please break it up at 72 columns.
> 
> >And your space around the '.' is odd :(
> 
> Yes,fixing it.
>
^^^^^^^^^^^^^^^^^^^^

You are still using spaces the wrong way :) 

English, as well as all natural languages that use Latin characters, use 
punctuation and a strict style that dictates how to use the spaces around it. 
Please read correctly written English texts, learn and use conventions

Thanks,

Fabio 
> 
> >> checkpatch warning : Too many leading tabs - consider code refactoring
> 
> >What does this mean?
> Asking about the warning ,correct?
> The current code is using very deep indentations (which can be avoided) and
> due to this there are many leading tabs. So the checkpatch.pl warns of  
"Too
> many leading tabs - consider code refactoring"
> <http://checkpatch.pl>
> 
> On Mon, Oct 25, 2021 at 1:03 PM Greg KH <gregkh@...uxfoundation.org> wrote:
> 
> > On Mon, Oct 25, 2021 at 12:55:28PM +0530, Kushal Kothari wrote:
> > > Refactor nested if else by combining nested if into a single if
> > condition and removing unnecessary else conditionals which leads to
> > removing unnecessary tabs .There is no change in logic of new code.
> >
> > Very long line, please break it up at 72 columns.
> >
> > And your space around the '.' is odd :(
> >
> > > checkpatch warning : Too many leading tabs - consider code refactoring
> >
> > What does this mean?
> >
> > >
> > > Signed-off-by: Kushal Kothari <kushalkothari285@...il.com>
> > > ---
> > >  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 65 ++++++++-----------
> > >  1 file changed, 26 insertions(+), 39 deletions(-)
> > >
> >
> > thanks,
> >
> > greg k-h
> >
>