linux-kernel - Re: [PATCH -next] irqchip/mchp-eic: Fix return value check in mchp_eic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ee89bdm1.wl-maz@kernel.org>
Date:   Mon, 25 Oct 2021 11:30:46 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     <Claudiu.Beznea@...rochip.com>
Cc:     <yangyingliang@...wei.com>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH -next] irqchip/mchp-eic: Fix return value check in mchp_eic_init()

On Mon, 25 Oct 2021 10:40:15 +0100,
<Claudiu.Beznea@...rochip.com> wrote:
> 
> On 25.10.2021 10:44, Claudiu Beznea - M18063 wrote:
> > On 25.10.2021 08:00, Yang Yingliang wrote:
> >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >>
> >> In case of error, the function of_iomap() returns NULL pointer
> >> not ERR_PTR(). The IS_ERR() test in the return value check
> >> should be replaced with NULL test.
> >>
> >> Reported-by: Hulk Robot <hulkci@...wei.com>
> >> Signed-off-by: Yang Yingliang <yangyingliang@...wei.
> > Reviewed-by: Claudiu Beznea <claudiu.beznea@...rochip.com>
> 
> Forgot to mention, can you add the Fixes tag?

There is no real need for one when the offending patch is in the same
merge window, and will be in the same pull request.

	M.

-- 
Without deviation from the norm, progress is not possible.