lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 Oct 2021 14:38:14 +0300 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Hans de Goede <hdegoede@...hat.com> Cc: "Rafael J . Wysocki" <rjw@...ysocki.net>, Mark Gross <markgross@...nel.org>, Andy Shevchenko <andy@...radead.org>, Wolfram Sang <wsa@...-dreams.de>, Mika Westerberg <mika.westerberg@...ux.intel.com>, Daniel Scally <djrscally@...il.com>, Laurent Pinchart <laurent.pinchart@...asonboard.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Len Brown <lenb@...nel.org>, ACPI Devel Maling List <linux-acpi@...r.kernel.org>, Platform Driver <platform-driver-x86@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-i2c <linux-i2c@...r.kernel.org>, Sakari Ailus <sakari.ailus@...ux.intel.com>, Kate Hsuan <hpa@...hat.com>, Linux Media Mailing List <linux-media@...r.kernel.org>, linux-clk <linux-clk@...r.kernel.org> Subject: Re: [PATCH v4 10/11] platform/x86: int3472: Pass tps68470_regulator_platform_data to the tps68470-regulator MFD-cell On Mon, Oct 25, 2021 at 12:42 PM Hans de Goede <hdegoede@...hat.com> wrote: > > Pass tps68470_regulator_platform_data to the tps68470-regulator > MFD-cell, specifying the voltages of the various regulators and > tying the regulators to the sensor supplies so that sensors which use > the TPS68470 can find their regulators. > > Since the voltages and supply connections are board-specific, this > introduces a DMI matches int3472_tps68470_board_data struct which > contains the necessary per-board info. > > This per-board info also includes GPIO lookup information for the > sensor GPIOs which may be connected to the tps68470 gpios. gpios --> GPIO lines ... > + board_data = int3472_tps68470_get_board_data(dev_name(&client->dev)); > + if (board_data) IIRC it's a dup. Below already incorporates this. > + gpiod_remove_lookup_table(board_data->tps68470_gpio_lookup_table); ... > +const struct int3472_tps68470_board_data *int3472_tps68470_get_board_data(const char *dev_name) > +{ > + const struct int3472_tps68470_board_data *board_data; > + const struct dmi_system_id *match; > + > + match = dmi_first_match(int3472_tps68470_board_data_table); > + while (match) { > + board_data = match->driver_data; > + if (strcmp(board_data->dev_name, dev_name) == 0) > + return board_data; > + > + dmi_first_match(++match); > + } > + > + return NULL; Sounds like a déjà-vu for the code seeing somewhere under sound/soc or so. Perhaps a TODO for eliminating the dup? (Yes, it's out of scope of this series) > +} -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists