lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 Oct 2021 12:11:43 +0000 From: Abhyuday Godhasara <agodhasa@...inx.com> To: Greg KH <gregkh@...uxfoundation.org> CC: Michal Simek <michals@...inx.com>, Rajan Vaja <RAJANV@...inx.com>, Manish Narani <MNARANI@...inx.com>, "zou_wei@...wei.com" <zou_wei@...wei.com>, Sai Krishna Potthuri <lakshmis@...inx.com>, Jiaying Liang <jliang@...inx.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Tejas Patel <TEJASP@...inx.com> Subject: RE: [PATCH v6 1/6] firmware: xilinx: add register notifier in zynqmp firmware Hi Greg, > -----Original Message----- > From: Greg KH <gregkh@...uxfoundation.org> > Sent: Monday, October 25, 2021 5:33 PM > To: Abhyuday Godhasara <agodhasa@...inx.com> > Cc: Michal Simek <michals@...inx.com>; Rajan Vaja <RAJANV@...inx.com>; > Manish Narani <MNARANI@...inx.com>; zou_wei@...wei.com; Sai Krishna > Potthuri <lakshmis@...inx.com>; Jiaying Liang <jliang@...inx.com>; linux- > kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; Tejas Patel > <TEJASP@...inx.com> > Subject: Re: [PATCH v6 1/6] firmware: xilinx: add register notifier in zynqmp > firmware > > On Mon, Oct 25, 2021 at 11:53:17AM +0000, Abhyuday Godhasara wrote: > > Hi Greg, > > > > > -----Original Message----- > > > From: Greg KH <gregkh@...uxfoundation.org> > > > Sent: Monday, October 25, 2021 2:05 PM > > > To: Abhyuday Godhasara <agodhasa@...inx.com> > > > Cc: Michal Simek <michals@...inx.com>; Rajan Vaja > > > <RAJANV@...inx.com>; Manish Narani <MNARANI@...inx.com>; > > > zou_wei@...wei.com; Sai Krishna Potthuri <lakshmis@...inx.com>; > > > Jiaying Liang <jliang@...inx.com>; Jiaying Liang > > > <jliang@...inx.com>; linux-kernel@...r.kernel.org; linux-arm- > > > kernel@...ts.infradead.org; Tejas Patel <TEJASP@...inx.com> > > > Subject: Re: [PATCH v6 1/6] firmware: xilinx: add register notifier > > > in zynqmp firmware > > > > > > On Mon, Oct 25, 2021 at 01:23:45AM -0700, Abhyuday Godhasara wrote: > > > > In zynqmp-firmware, register notifier is not supported, add > > > > support of register notifier in zynqmp-firmware. > > > > > > > > Signed-off-by: Tejas Patel <tejas.patel@...inx.com> > > > > Signed-off-by: Abhyuday Godhasara <abhyuday.godhasara@...inx.com> > > > > Acked-by: Michal Simek <michal.simek@...inx.com> > > > > --- > > > > Changes in v6: > > > > - Minor fix > > > > > > > > > That is vague, what got "fixed" here? > > [Abhyuday] During rebase of patches on your tree couple of lines code was > get mixed unintendedly in xlnx-zynqmp.h header file due to use of "git am -3". > > I corrected the below code which was wrong in previous patch v5. > > +static inline int zynqmp_pm_register_notifier(const u32 node, const u32 > event, > > + const u32 wake, const u32 enable) > { > > + return -ENODEV; > > +} > > > > In v5 it was like below, which is wrong static inline int > > zynqmp_pm_load_pdi(const u32 src, const u64 address) static inline int > > zynqmp_pm_register_notifier(const u32 node, const u32 event, > > const u32 wake, const u32 enable) > { > > return -ENODEV; > > } > > So, the body was missing here for zynqmp_pm_load_pdi in v5. > > And why did you not describe this in the changelog text? That is what I was > asking about here. Please be specific, as reviewers need to know this type of > thing. [Abhyuday] Just to avoid longer change log I added it as "Minor fix" this time, but will be taken care this type of things from next time. Are you expecting the v7 for this time ? Thanks, Abhyuday > > thanks, > > greg k-h
Powered by blists - more mailing lists