linux-kernel - Re: [PATCH v2 1/2] crypto: use SM3 instead of SM3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0997d70b-9f28-ba0a-853f-2160922dc722@linux.alibaba.com>
Date:   Mon, 25 Oct 2021 11:04:02 +0800
From:   Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
To:     Jarkko Sakkinen <jarkko@...nel.org>,
        James Bottomley <jejb@...ux.ibm.com>,
        Mimi Zohar <zohar@...ux.ibm.com>,
        Jonathan Corbet <corbet@....net>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Peter Huewe <peterhuewe@....de>,
        Jason Gunthorpe <jgg@...pe.ca>,
        David Howells <dhowells@...hat.com>,
        James Morris <jmorris@...ei.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        Jerry Snitselaar <jsnitsel@...hat.com>,
        linux-integrity@...r.kernel.org, keyrings@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-crypto@...r.kernel.org, linux-security-module@...r.kernel.org
Subject: Re: [PATCH v2 1/2] crypto: use SM3 instead of SM3_256

Hi Jarkko,

On 10/23/21 8:48 AM, Jarkko Sakkinen wrote:
> On Tue, 2021-10-19 at 18:04 +0800, Tianjia Zhang wrote:
>> According to https://tools.ietf.org/id/draft-oscca-cfrg-sm3-01.html,
>> SM3 always produces a 256-bit hash value and there are no plans for
>> other length development, so there is no ambiguity in the name of sm3.
>>
>> Suggested-by: James Bottomley <jejb@...ux.ibm.com>
>> Signed-off-by: Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
>> ---
>>   Documentation/security/keys/trusted-encrypted.rst | 2 +-
>>   crypto/hash_info.c                                | 4 ++--
>>   drivers/char/tpm/tpm2-cmd.c                       | 2 +-
>>   include/crypto/hash_info.h                        | 2 +-
>>   include/uapi/linux/hash_info.h                    | 3 ++-
>>   security/keys/trusted-keys/trusted_tpm2.c         | 2 +-
>>   6 files changed, 8 insertions(+), 7 deletions(-)
>>
>> diff --git a/Documentation/security/keys/trusted-encrypted.rst b/Documentation/security/keys/trusted-encrypted.rst
>> index 80d5a5af62a1..3292461517f6 100644
>> --- a/Documentation/security/keys/trusted-encrypted.rst
>> +++ b/Documentation/security/keys/trusted-encrypted.rst
>> @@ -162,7 +162,7 @@ Usage::
>>                        default 1 (resealing allowed)
>>          hash=         hash algorithm name as a string. For TPM 1.x the only
>>                        allowed value is sha1. For TPM 2.x the allowed values
>> -                     are sha1, sha256, sha384, sha512 and sm3-256.
>> +                     are sha1, sha256, sha384, sha512 and sm3.
> 
> You cannot remove sm3-256 from uapi.
> 

Thanks for pointing it out, Maybe this fix is more appropriate in patch 2.

Best regards,
Tianjia