linux-kernel - Re: [PATCH v2 00/10] Add MT7921 SDIO Bluetooth support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <63D47354-AEEA-4019-8C12-FEECD860BB85@holtmann.org>
Date:   Mon, 25 Oct 2021 15:37:25 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Sean Wang <sean.wang@...iatek.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        "Mark-YW Chen (陳揚文)" 
        <Mark-YW.Chen@...iatek.com>, Soul.Huang@...iatek.com,
        YN.Chen@...iatek.com, Leon.Yen@...iatek.com,
        Eric-SY.Chang@...iatek.com, Deren.Wu@...iatek.com,
        km.lin@...iatek.com, robin.chiu@...iatek.com,
        Eddie.Chen@...iatek.com, ch.yeh@...iatek.com,
        posh.sun@...iatek.com, ted.huang@...iatek.com,
        Eric.Liang@...iatek.com, Stella.Chang@...iatek.com,
        Tom.Chou@...iatek.com, steve.lee@...iatek.com, jsiuda@...gle.com,
        frankgor@...gle.com, jemele@...gle.com, abhishekpandit@...gle.com,
        michaelfsun@...gle.com, mcchou@...omium.org, shawnku@...gle.com,
        linux-bluetooth@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Sean Wang <objelf@...il.com>
Subject: Re: [PATCH v2 00/10] Add MT7921 SDIO Bluetooth support

Hi Sean,

> The patchset adds the MT7921 SDIO (MT7921S) Blutooth support to btmtksdio
> driver, which basically are made up of 3 parts.
> 
> PART 1: patch 1-3 to create btmtk module to rely on
> 
> These are preliminary patches for MT7921s driver to move the common
> firmware download procedure and the common functions from MT7921u to btmtk
> module to make MT7921u, MT7921s and other devices can share with to reduce
> the unnecessary duplicated code being created.
> 
> PART 2: patch 4-8 to refactor btmtksdio prior to adding mt7921s
> 
> These are preliminary patches for MT7921s driver to refactor the current
> btmtksdio to make MT7921S is able to coexist with the devices the current
> driver can support with the generic code and improve the performance on
> packet transmitting and receving process.
> 
> PART 3: patch 9-10 to add specific mt7921s logic
> 
> Add the specific logic regarding to mt7921s bluetooth.
> 
> The changelog from v1 to v2:
> - fix the test failure reported from bluez test bot
> - fix the test warning reported from kernel test robot
> - rebase onto the up-to-date bluetooth-next/master 
> - fix the typo from mt7961_data to mt7921_data
> - improve the function btsdio_mtk_reg_read with dropping the hard coding
> 
> Mark-yw Chen (1):
>  Bluetooth: btmtksdio: transmit packet according to status TX_EMPTY
> 
> Sean Wang (9):
>  Bluetooth: mediatek: add BT_MTK module
>  Bluetooth: btmtksido: rely on BT_MTK module
>  Bluetooth: btmtksdio: add .set_bdaddr support
>  Bluetooth: btmtksdio: explicitly set WHISR as write-1-clear
>  Bluetooth: btmtksdio: move interrupt service to work
>  Bluetooth: btmtksdio: update register CSDIOCSR operation
>  Bluetooth: btmtksdio: use register CRPLR to read packet length
>  mmc: add MT7921 SDIO identifiers for MediaTek Bluetooth devices
>  Bluetooth: btmtksdio: add MT7921s Bluetooth support
> 
> drivers/bluetooth/Kconfig     |   6 +
> drivers/bluetooth/Makefile    |   1 +
> drivers/bluetooth/btmtk.c     | 289 ++++++++++++++++++++
> drivers/bluetooth/btmtk.h     | 111 ++++++++
> drivers/bluetooth/btmtksdio.c | 496 +++++++++++++++++-----------------
> drivers/bluetooth/btusb.c     | 331 +----------------------
> include/linux/mmc/sdio_ids.h  |   1 +
> 7 files changed, 658 insertions(+), 577 deletions(-)
> create mode 100644 drivers/bluetooth/btmtk.c
> create mode 100644 drivers/bluetooth/btmtk.h

all 10 patches have been applied to bluetooth-next tree.

Regards

Marcel