lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 Oct 2021 03:15:19 +0000 From: "lizhijian@...itsu.com" <lizhijian@...itsu.com> To: "paulmck@...nel.org" <paulmck@...nel.org>, "lizhijian@...itsu.com" <lizhijian@...itsu.com> CC: "dave@...olabs.net" <dave@...olabs.net>, "josh@...htriplett.org" <josh@...htriplett.org>, "rostedt@...dmis.org" <rostedt@...dmis.org>, "mathieu.desnoyers@...icios.com" <mathieu.desnoyers@...icios.com>, "jiangshanlai@...il.com" <jiangshanlai@...il.com>, "joel@...lfernandes.org" <joel@...lfernandes.org>, "rcu@...r.kernel.org" <rcu@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Philip Li <philip.li@...el.com>, kernel test robot <lkp@...el.com> Subject: Re: [PATCH 2/2] refscale: prevent buffer to pr_alert() being too long On 25/10/2021 06:56, Paul E. McKenney wrote: > >>>> if (!buf) >>>> return 0; >>>> buf[0] = 0; >>>> @@ -617,13 +617,15 @@ static u64 process_durations(int n) >>>> if (i % 5 == 0) >>>> strcat(buf, "\n"); >>>> + if (strlen(buf) > 800) { >>>> + pr_alert("%s", buf); >>> Does the tools/testing/selftests/rcutorture/bin/kvm-recheck-refscale.sh >>> script also require changes to handle the partial lines? Looks it doesn't matter for kvm-recheck-refscale.sh where it will not check these output. >>>> u32 rem; >>>> @@ -712,9 +711,13 @@ static int main_func(void *arg) >>>> avg = div_u64_rem(result_avg[exp], 1000, &rem); >>>> sprintf(buf1, "%d\t%llu.%03u\n", exp + 1, avg, rem); >>>> strcat(buf, buf1); >>>> + if (strlen(buf) > 800) { >>>> + pr_alert("%s", buf); >>>> + buf[0] = 0; >>>> + } >>>> } >>>> - SCALEOUT("%s", buf); >>>> + pr_alert("%s", buf); it will not introduce partial lines here, buf is always ended with '\n' I have checked the regexp in tools/testing/selftests/rcutorture/bin/kvm-recheck-refscale.sh and verify it with the new result, it always works. Thanks Zhijian >>>> err: >>>> // This will shutdown everything including us. >>>> -- >>>> 2.33.0 >>>> >>>> >>>> >> >
Powered by blists - more mailing lists