linux-kernel - Re: [PATCH v2 0/5] Refactor thermal pressure update to avoid code duplication

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3cc80fea-1320-9a1a-9954-85b30f3d933a@arm.com>
Date:   Mon, 25 Oct 2021 17:43:11 +0100
From:   Lukasz Luba <lukasz.luba@....com>
To:     rafael@...nel.org, viresh.kumar@...aro.org,
        daniel.lezcano@...aro.org
Cc:     linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org, sudeep.holla@....com,
        will@...nel.org, catalin.marinas@....com, linux@...linux.org.uk,
        gregkh@...uxfoundation.org, amitk@...nel.org,
        amit.kachhap@...il.com, thara.gopinath@...aro.org,
        bjorn.andersson@...aro.org, agross@...nel.org
Subject: Re: [PATCH v2 0/5] Refactor thermal pressure update to avoid code
 duplication


On 10/15/21 3:45 PM, Lukasz Luba wrote:
> Hi all,
> 
> This patch set v2 aims to refactor the thermal pressure update
> code. There are already two clients which do similar thing:
> convert the capped frequency value into the capacity of
> affected CPU and call the 'set' function to store the
> reduced capacity into the per-cpu variable.
> There might be more than two of these users. In near future
> it will be scmi-cpufreq driver, which receives notification
> from FW about reduced frequency due to thermal. Other vendors
> might follow. Let's avoid code duplication and potential
> conversion bugs. Move the conversion code into the arch_topology.c
> where the capacity calculation setup code and thermal pressure sit.
> 
> Apart from that $subject patches, there is one patch (3/5) which fixes
> issue in qcom-cpufreq-hw.c when the thermal pressure is not
> updated for offline CPUs. It's similar fix that has been merged
> recently for cpufreq_cooling.c:
> 2ad8ccc17d1e4270cf65a3f2
> 
> Changes:
> v2:
> - added Reviewed-by from Thara for patch 3/5
> - changed the doxygen comment and used mult_frac()
>    according to Thara's suggestion in patch 1/5
> v1 -> [1]
> 

Gentle ping.

Viresh, Daniel, Rafael could you have a look at this, please?

Regards,
Lukasz