linux-kernel - Re: [PATCH] net: macb: Fix mdio child node detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84fd2f86-7f94-dab9-184d-49e87cede579@seco.com>
Date:   Tue, 26 Oct 2021 13:42:08 -0400
From:   Sean Anderson <sean.anderson@...o.com>
To:     Guenter Roeck <linux@...ck-us.net>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>
Cc:     Claudiu Beznea <claudiu.beznea@...rochip.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH] net: macb: Fix mdio child node detection



On 10/26/21 1:39 PM, Guenter Roeck wrote:
> Commit 4d98bb0d7ec2 ("net: macb: Use mdio child node for MDIO bus if it
> exists") added code to detect if a 'mdio' child node exists to the macb
> driver. Ths added code does, however, not actually check if the child node
> exists, but if the parent node exists. This results in errors such as
> 
> macb 10090000.ethernet eth0: Could not attach PHY (-19)
> 
> if there is no 'mdio' child node. Fix the code to actually check for
> the child node.
> 
> Fixes: 4d98bb0d7ec2 ("net: macb: Use mdio child node for MDIO bus if it exists")
> Cc: Sean Anderson <sean.anderson@...o.com>
> Cc: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
>   drivers/net/ethernet/cadence/macb_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 309371abfe23..ffce528aa00e 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -901,7 +901,7 @@ static int macb_mdiobus_register(struct macb *bp)
>   	 * directly under the MAC node
>   	 */
>   	child = of_get_child_by_name(np, "mdio");
> -	if (np) {
> +	if (child) {
>   		int ret = of_mdiobus_register(bp->mii_bus, child);
>   
>   		of_node_put(child);
> 

Thanks for catching this.

Reviewed-by: Sean Anderson <sean.anderson@...o.com>