lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 Oct 2021 21:45:43 +0200 From: Daniel Bristot de Oliveira <bristot@...nel.org> To: Steven Rostedt <rostedt@...dmis.org>, Tao Zhou <tao.zhou@...ux.dev> Cc: Ingo Molnar <mingo@...hat.com>, Tom Zanussi <zanussi@...nel.org>, Masami Hiramatsu <mhiramat@...nel.org>, Juri Lelli <juri.lelli@...hat.com>, Clark Williams <williams@...hat.com>, John Kacur <jkacur@...hat.com>, Peter Zijlstra <peterz@...radead.org>, Thomas Gleixner <tglx@...utronix.de>, Sebastian Andrzej Siewior <bigeasy@...utronix.de>, linux-rt-users@...r.kernel.org, linux-trace-devel@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH V5 08/20] rtla: Helper functions for rtla On 10/26/21 18:26, Steven Rostedt wrote: > On Wed, 27 Oct 2021 00:22:04 +0800 > Tao Zhou <tao.zhou@...ux.dev> wrote: > >>> + do { >>> + retval = read(in_fd, buffer, sizeof(buffer)); >>> + if (read <= 0) >> check "retval" not read. Like: >> >> if (retval <= 0) > OUCH! Good check. > > Daniel, did that not produce any warnings?? OUCH OUCH! No warnings, no nothing. The code actually "works" because errors are not common and the next if stops the loop. -- Daniel > -- Steve > >
Powered by blists - more mailing lists