linux-kernel - Re: linux-next: build failure after merge of the pinctrl tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dad7a9b1-6521-801c-d8b8-75dca8a4bfdd@gmail.com>
Date:   Wed, 27 Oct 2021 00:21:29 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Prathamesh Shete <pshete@...dia.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Linus Walleij <linus.walleij@...aro.org>
Cc:     "Kartik ." <kkartik@...dia.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the pinctrl tree

26.10.2021 15:30, Prathamesh Shete пишет:
> Fixed following warnings and error.
> Attached the patch that fixes the issue.
> Please help apply the Patch.
> 
> Thanks
> Prathamesh.
> 
> -----Original Message-----
> From: Stephen Rothwell <sfr@...b.auug.org.au> 
> Sent: Tuesday, October 26, 2021 10:59 AM
> To: Linus Walleij <linus.walleij@...aro.org>
> Cc: Kartik . <kkartik@...dia.com>; Prathamesh Shete <pshete@...dia.com>; Linux Kernel Mailing List <linux-kernel@...r.kernel.org>; Linux Next Mailing List <linux-next@...r.kernel.org>
> Subject: linux-next: build failure after merge of the pinctrl tree
> 
> Hi all,
> 
> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/pinctrl/tegra/pinctrl-tegra.c: In function 'tegra_pinctrl_get_group':
> drivers/pinctrl/tegra/pinctrl-tegra.c:293:12: warning: return discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>   293 |     return &pmx->soc->groups[group];
>       |            ^~~~~~~~~~~~~~~~~~~~~~~~
> drivers/pinctrl/tegra/pinctrl-tegra.c:282:25: warning: unused variable 'g' [-Wunused-variable]
>   282 |  struct tegra_pingroup *g;
>       |                         ^
> drivers/pinctrl/tegra/pinctrl-tegra.c: In function 'tegra_pinctrl_gpio_disable_free':
> drivers/pinctrl/tegra/pinctrl-tegra.c:341:10: error: 'return' with a value, in function returning void [-Werror=return-type]
>   341 |   return -EINVAL;
>       |          ^
> drivers/pinctrl/tegra/pinctrl-tegra.c:327:13: note: declared here
>   327 | static void tegra_pinctrl_gpio_disable_free(struct pinctrl_dev *pctldev,
>       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   a42c7d95d29e ("pinctrl: tegra: Use correct offset for pin group")
> 
> I have used the pinctrl tree from next-20211025 for today.
> 

The tegra_pinctrl_get_group() should return const and not cast the
pointers. Please make another patch to fix it properly.