linux-kernel - Re: [PATCH V5 10/20] rtla/osnoise: Add osnoise top mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46ffc66d-26da-7ac5-0f3f-e86594d2b60c@kernel.org>
Date:   Tue, 26 Oct 2021 21:50:57 +0200
From:   Daniel Bristot de Oliveira <bristot@...nel.org>
To:     Tao Zhou <tao.zhou@...ux.dev>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        Tom Zanussi <zanussi@...nel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Clark Williams <williams@...hat.com>,
        John Kacur <jkacur@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        linux-rt-users@...r.kernel.org, linux-trace-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V5 10/20] rtla/osnoise: Add osnoise top mode

On 10/26/21 18:32, Tao Zhou wrote:
>> +	if (params->stop_us)
>> +		osnoise_set_stop_us(tool->context, params->stop_us);
> osnoise_set_stop_us() also need to check return value feels by me.
> 
>> +
>> +	if (params->stop_total_us)
>> +		osnoise_set_stop_total_us(tool->context, params->stop_total_us);
> The same here. Also need to check the return value.
> 
> PATCH 10 also has these two places(call the two functions) that not check
> the return value.
> 
> Or I am wrong.


You are right, reviewing that.

Thanks!
-- Daniel

> 
> 
> Thanks,
> Tao
>