linux-kernel - Re: [PATCH RFC] cpuset: Make cpusets get restored on hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211026235808.34168-1-21cnbao@gmail.com>
Date:   Wed, 27 Oct 2021 12:58:08 +1300
From:   Barry Song <21cnbao@...il.com>
To:     longman@...hat.com
Cc:     amit.pundir@...aro.org, cgroups@...r.kernel.org,
        dimitrysh@...gle.com, groeck@...omium.org, hannes@...xchg.org,
        joel@...lfernandes.org, jsbarnes@...gle.com,
        kernel-team@...roid.com, kerrnel@...gle.com,
        linux-kernel@...r.kernel.org, lizefan@...wei.com,
        peterz@...radead.org, sonnyrao@...gle.com, tj@...nel.org,
        vpillai@...italocean.com
Subject: Re: [PATCH RFC] cpuset: Make cpusets get restored on hotplug

> I think Tejun is concerned about a change in the default behavior of
> cpuset v1.
>
> There is a special v2 mode for cpuset that is enabled by the mount
> option "cpuset_v2_mode". This causes the cpuset v1 to adopt some of the
> v2 behavior. I introduced this v2 mode a while back to address, I think,
> a similar concern. Could you try that to see if it is able to address
> your problem? If not, you can make some code adjustment within the
> framework of the v2 mode. As long as it is an opt-in, I think we are
> open to further change.

I am also able to reproduce on Ubuntu 21.04 LTS.

all docker will be put in this cgroups and its child cgroups:
/sys/fs/cgroup/cpuset/docker

disabling and enabling SMT by:
echo off > /sys/devices/system/cpu/smt/control
echo on > /sys/devices/system/cpu/smt/control

or unpluging and pluging CPUs by:
echo 0 > /sys/devices/system/cpu/cpuX/online
echo 1 > /sys/devices/system/cpu/cpuX/online

then all docker images will lose some CPUs.

So should we document the broken behaviours somewhere?

Thanks
barry