linux-kernel - [PATCH] io-wq: Remove unnecessary rcu_read_lock/unlock() in raw spinlock critical section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211026032304.30323-1-qiang.zhang1211@gmail.com>
Date:   Tue, 26 Oct 2021 11:23:04 +0800
From:   Zqiang <qiang.zhang1211@...il.com>
To:     axboe@...nel.dk, asml.silence@...il.com, io-uring@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Zqiang <qiang.zhang1211@...il.com>
Subject: [PATCH] io-wq: Remove unnecessary rcu_read_lock/unlock() in raw spinlock critical section

Due to raw_spin_lock/unlock() contains preempt_disable/enable() action,
already regarded as RCU critical region, so remove unnecessary
rcu_read_lock/unlock().

Signed-off-by: Zqiang <qiang.zhang1211@...il.com>
---
 fs/io-wq.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/io-wq.c b/fs/io-wq.c
index cd88602e2e81..401be005d089 100644
--- a/fs/io-wq.c
+++ b/fs/io-wq.c
@@ -855,9 +855,7 @@ static void io_wqe_enqueue(struct io_wqe *wqe, struct io_wq_work *work)
 	io_wqe_insert_work(wqe, work);
 	clear_bit(IO_ACCT_STALLED_BIT, &acct->flags);
 
-	rcu_read_lock();
 	do_create = !io_wqe_activate_free_worker(wqe, acct);
-	rcu_read_unlock();
 
 	raw_spin_unlock(&wqe->lock);
 
-- 
2.17.1