linux-kernel - Re: [PATCH v2 3/3] serial: 8250_pci: Replace dev_*() by pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f7e1a82-7afc-b4e6-77b8-699607d5c994@kernel.org>
Date:   Tue, 26 Oct 2021 07:20:45 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] serial: 8250_pci: Replace dev_*() by pci_*()
 macros

On 22. 10. 21, 15:51, Andy Shevchenko wrote:
> PCI subsystem provides convenient shortcut macros for message printing.
> Use those macros instead of dev_*().

Hopefully they are preferred by the PCI maintainer too :)...

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Reviewed-by: Jiri Slaby <jslaby@...nel.org>

> ---
> v2: dropped unrelated change (Joe)
>   drivers/tty/serial/8250/8250_pci.c | 52 +++++++++++++-----------------
>   1 file changed, 22 insertions(+), 30 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
> index 463b2c71da6f..aea12263a1ff 100644
> --- a/drivers/tty/serial/8250/8250_pci.c
> +++ b/drivers/tty/serial/8250/8250_pci.c
> @@ -75,13 +75,12 @@ static int pci_default_setup(struct serial_private*,
>   
>   static void moan_device(const char *str, struct pci_dev *dev)
>   {
> -	dev_err(&dev->dev,
> -	       "%s: %s\n"
> +	pci_err(dev, "%s\n"
>   	       "Please send the output of lspci -vv, this\n"
>   	       "message (0x%04x,0x%04x,0x%04x,0x%04x), the\n"
>   	       "manufacturer and name of serial board or\n"
>   	       "modem board to <linux-serial@...r.kernel.org>.\n",
> -	       pci_name(dev), str, dev->vendor, dev->device,
> +	       str, dev->vendor, dev->device,
>   	       dev->subsystem_vendor, dev->subsystem_device);
>   }
>   
...

-- 
js
suse labs