linux-kernel - Re: [PATCH v2 03/21] perf pmu: Make pmu_sys_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 26 Oct 2021 10:56:00 +0530
From:   kajoljain <kjain@...ux.ibm.com>
To:     Ian Rogers <irogers@...gle.com>, Andi Kleen <ak@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Jin Yao <yao.jin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        John Garry <john.garry@...wei.com>,
        "Paul A . Clarke" <pc@...ibm.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Riccardo Mancini <rickyman7@...il.com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Kees Cook <keescook@...omium.org>,
        Sami Tolvanen <samitolvanen@...gle.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jacob Keller <jacob.e.keller@...el.com>,
        Zhen Lei <thunder.leizhen@...wei.com>,
        ToastC <mrtoastcheng@...il.com>,
        Joakim Zhang <qiangqing.zhang@....com>,
        Felix Fietkau <nbd@....name>,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        Song Liu <songliubraving@...com>, Fabian Hemmer <copy@...y.sh>,
        Alexander Antonov <alexander.antonov@...ux.intel.com>,
        Nicholas Fraser <nfraser@...eweavers.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Denys Zagorui <dzagorui@...co.com>,
        Wan Jiabing <wanjiabing@...o.com>,
        Thomas Richter <tmricht@...ux.ibm.com>,
        Sumanth Korikkar <sumanthk@...ux.ibm.com>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Changbin Du <changbin.du@...el.com>,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        Andrew Kilroy <andrew.kilroy@....com>
Cc:     Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH v2 03/21] perf pmu: Make pmu_sys_event_tables const.



On 10/15/21 10:51 PM, Ian Rogers wrote:
> Make lookup nature of data structures clearer through their type.
> 
> Acked-by: Andi Kleen <ak@...ux.intel.com>
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
>  tools/perf/pmu-events/jevents.c    | 2 +-
>  tools/perf/pmu-events/pmu-events.h | 2 +-
>  tools/perf/tests/pmu-events.c      | 2 +-
>  tools/perf/util/pmu.c              | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)

Patch looks good to me.

Reviewed-by: Kajol Jain<kjain@...ux.ibm.com>

Thanks,
Kajol Jain

> 
> diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
> index 5624a37d6f93..a31de0f77097 100644
> --- a/tools/perf/pmu-events/jevents.c
> +++ b/tools/perf/pmu-events/jevents.c
> @@ -832,7 +832,7 @@ static void print_mapping_test_table(FILE *outfp)
>  
>  static void print_system_event_mapping_table_prefix(FILE *outfp)
>  {
> -	fprintf(outfp, "\nstruct pmu_sys_events pmu_sys_event_tables[] = {");
> +	fprintf(outfp, "\nconst struct pmu_sys_events pmu_sys_event_tables[] = {");
>  }
>  
>  static void print_system_event_mapping_table_suffix(FILE *outfp)
> diff --git a/tools/perf/pmu-events/pmu-events.h b/tools/perf/pmu-events/pmu-events.h
> index 42c6db6bedec..f6c9c9fc4ab2 100644
> --- a/tools/perf/pmu-events/pmu-events.h
> +++ b/tools/perf/pmu-events/pmu-events.h
> @@ -54,6 +54,6 @@ struct pmu_sys_events {
>   * table of PMU events.
>   */
>  extern const struct pmu_events_map pmu_events_map[];
> -extern struct pmu_sys_events pmu_sys_event_tables[];
> +extern const struct pmu_sys_events pmu_sys_event_tables[];
>  
>  #endif
> diff --git a/tools/perf/tests/pmu-events.c b/tools/perf/tests/pmu-events.c
> index 8a1fdcd072f5..c0f8b61871c8 100644
> --- a/tools/perf/tests/pmu-events.c
> +++ b/tools/perf/tests/pmu-events.c
> @@ -258,7 +258,7 @@ static const struct pmu_events_map *__test_pmu_get_events_map(void)
>  
>  static struct pmu_event *__test_pmu_get_sys_events_table(void)
>  {
> -	struct pmu_sys_events *tables = &pmu_sys_event_tables[0];
> +	const struct pmu_sys_events *tables = &pmu_sys_event_tables[0];
>  
>  	for ( ; tables->name; tables++) {
>  		if (!strcmp("pme_test_soc_sys", tables->name))
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index 4bcdc595ce5e..c04a89cc7cef 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -873,7 +873,7 @@ void pmu_for_each_sys_event(pmu_sys_event_iter_fn fn, void *data)
>  	int i = 0;
>  
>  	while (1) {
> -		struct pmu_sys_events *event_table;
> +		const struct pmu_sys_events *event_table;
>  		int j = 0;
>  
>  		event_table = &pmu_sys_event_tables[i++];
>