linux-kernel - Re: [PATCH] ASoC: tegra: Add master volume/mute control support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 26 Oct 2021 11:53:30 +0530
From:   Sameer Pujar <spujar@...dia.com>
To:     Jaroslav Kysela <perex@...ex.cz>, broonie@...nel.org,
        lgirdwood@...il.com, tiwai@...e.com
Cc:     jonathanh@...dia.com, thierry.reding@...il.com,
        alsa-devel@...a-project.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: tegra: Add master volume/mute control support



On 10/25/2021 6:28 PM, Jaroslav Kysela wrote:
> On 25. 10. 21 13:06, Sameer Pujar wrote:
>
>> @@ -150,11 +186,22 @@ static int tegra210_mvc_put_mute(struct 
>> snd_kcontrol *kcontrol,
>
> ...
>>
>>       return 1;
>
> It's a bit unrelated comment to this change, but it may be worth to 
> verify all
> kcontrol put callbacks in the tegra code. Ensure that value 1 is 
> returned only
> when something was really changed in hardware.
>
> The tegra210_i2s_put_control() has opposite problem for example - returns
> always 0 which means that the change notifications are not send to 
> subscribed
> applications.
>

Thanks Jaroslav for review. I will keep a note to review put() calls in 
Tegra drivers and send fixes accordingly.