linux-kernel - Re: [PATCH v2 1/3] serial: 8250_pci: Refactor the loop in pci_ite887x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <415254a7-dcf2-75d8-2d92-6e3f568fc8b2@kernel.org>
Date:   Tue, 26 Oct 2021 08:51:57 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] serial: 8250_pci: Refactor the loop in
 pci_ite887x_init()

On 26. 10. 21, 8:44, Greg Kroah-Hartman wrote:
> On Tue, Oct 26, 2021 at 07:26:18AM +0200, Jiri Slaby wrote:
>> On 22. 10. 21, 15:51, Andy Shevchenko wrote:
>>> The loop can be refactored by using ARRAY_SIZE() instead of NULL terminator.
>>> This reduces code base and makes it easier to read and understand.
>>
>> Why don't we have array_for_each() BTW?
>>
>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>>
>> Reviewed-by: Jiri Slaby <jslaby@...nel.org>
> 
> And now my emails are bouncing as you typed your address incorrectly :(

Sorry for that. My WM currently crashes when I use key shortcuts (key 
input in plasma is not implemented under wayland). So I had to write 
those manually and screwed up. Let me improve my workflow now.

thanks,
-- 
js
suse labs