linux-kernel - drivers/clk/mediatek: 4 more suspected missing null check for return pointer of mtk_alloc_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <TYCP286MB11881F70BD0E5A1F25EC2A808A849@TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM>
Date:   Tue, 26 Oct 2021 07:32:54 +0000
From:   YE Chengfeng <cyeaa@...nect.ust.hk>
To:     "mturquette@...libre.com" <mturquette@...libre.com>,
        "sboyd@...nel.org" <sboyd@...nel.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: drivers/clk/mediatek: 4 more suspected missing null check for return
 pointer of mtk_alloc_clk_data

Hi,

These are 4 more missing null check for the return pointer of mtk_alloc_clk_data found by our static analysis tool. We manually check them and we think they are true problem. Would you like to have a look at them?

https://github.com/torvalds/linux/blob/master/drivers/clk/mediatek/clk-mt8135.c#L528
Missing null check at #line 528, potential null-pointer-dereference at #line 535.

https://github.com/torvalds/linux/blob/master/drivers/clk/mediatek/clk-mt8135.c#L549
Missing null check at #line 549, potential null-pointer-dereference at #line 554

https://github.com/torvalds/linux/blob/master/drivers/clk/mediatek/clk-mt7629.c#L605
Missing null check at #line 605, potential null-pointer-dereference at #line 610 (mtk_clk_register_cpumuxes will dereference the pointer clk_data)

https://github.com/torvalds/linux/blob/master/drivers/clk/mediatek/clk-mt7629.c#L582
Missing null check at #line 582, potential null-pointer-dereference at #line 593

Thanks so much,
Chengfeng