linux-kernel - [irqchip: irq/irqchip-next] MIPS: loongson64: Drop call to irq_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <163524452496.626.12676907731914820035.tip-bot2@tip-bot2>
Date:   Tue, 26 Oct 2021 10:35:24 -0000
From:   "irqchip-bot for Marc Zyngier" <tip-bot2@...utronix.de>
To:     linux-kernel@...r.kernel.org
Cc:     Marc Zyngier <maz@...nel.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Florian Fainelli <f.fainelli@...il.com>,
        Serge Semin <fancer.lancer@...il.com>, tglx@...utronix.de
Subject: [irqchip: irq/irqchip-next] MIPS: loongson64: Drop call to irq_cpu_offline()

The following commit has been merged into the irq/irqchip-next branch of irqchip:

Commit-ID:     eb5411334c289c473bc11d5cef8b0bea8d7ce324
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/eb5411334c289c473bc11d5cef8b0bea8d7ce324
Author:        Marc Zyngier <maz@...nel.org>
AuthorDate:    Thu, 21 Oct 2021 18:04:12 +01:00
Committer:     Marc Zyngier <maz@...nel.org>
CommitterDate: Tue, 26 Oct 2021 11:18:33 +01:00

MIPS: loongson64: Drop call to irq_cpu_offline()

Also loongson64 calls irq_cpu_offline(), none of its interrupt
controllers implement the .irq_cpu_offline callback.

It is thus obvious that this call only serves the dubious purpose
of wasting precious CPU cycles by iterating over all interrupts.

Get rid of the call altogether.

Signed-off-by: Marc Zyngier <maz@...nel.org>
Acked-by: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
Tested-by: Serge Semin <fancer.lancer@...il.com>
Link: https://lore.kernel.org/r/20211021170414.3341522-2-maz@kernel.org
---
 arch/mips/loongson64/smp.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/mips/loongson64/smp.c b/arch/mips/loongson64/smp.c
index 09ebe84..660e1de 100644
--- a/arch/mips/loongson64/smp.c
+++ b/arch/mips/loongson64/smp.c
@@ -550,7 +550,6 @@ static int loongson3_cpu_disable(void)
 	set_cpu_online(cpu, false);
 	calculate_cpu_foreign_map();
 	local_irq_save(flags);
-	irq_cpu_offline();
 	clear_c0_status(ST0_IM);
 	local_irq_restore(flags);
 	local_flush_tlb_all();