linux-kernel - Re: [PATCH 1/2] dt-bindings: power: supply: add Maxim MAX77976 battery charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fdc20f96-c407-b0e9-365d-264655a74844@lucaceresoli.net>
Date:   Tue, 26 Oct 2021 13:53:23 +0200
From:   Luca Ceresoli <luca@...aceresoli.net>
To:     Sebastian Reichel <sebastian.reichel@...labora.com>
Cc:     linux-pm@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: power: supply: add Maxim MAX77976
 battery charger

Hi Sebastian,

On 06/10/21 18:15, Sebastian Reichel wrote:
> Hi,
> 
> On Mon, Oct 04, 2021 at 03:07:31PM +0200, Luca Ceresoli wrote:
>> Add bindings for the Maxim MAX77976 I2C-controlled battery charger.
>>
>> Signed-off-by: Luca Ceresoli <luca@...aceresoli.net>
>> ---
>>  .../bindings/power/supply/maxim,max77976.yaml | 41 +++++++++++++++++++
>>  MAINTAINERS                                   |  5 +++
>>  2 files changed, 46 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/power/supply/maxim,max77976.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max77976.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max77976.yaml
>> new file mode 100644
>> index 000000000000..b508d9cc04a0
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/power/supply/maxim,max77976.yaml
>> @@ -0,0 +1,41 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/power/supply/maxim,max77976.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Maxim Integrated MAX77976 Battery charger
>> +
>> +maintainers:
>> +  - Luca Ceresoli <luca@...aceresoli.net>
>> +
>> +description: |
>> +  The Maxim MAX77976 is a 19Vin / 5.5A, 1-Cell Li+ battery charger
>> +  configured via I2C.
>> +
>> +properties:
>> +  compatible:
>> +    const: maxim,max77976
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +
>> +additionalProperties: false
> 
> Add
> 
> allOf:
>   - $ref: power-supply.yaml#
> 
> and replace additionalProperties with unevaluatedProperties, so that
> the power-supplies property is also valid.

OK, will fix.

-- 
Luca