lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 25 Oct 2021 21:08:43 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Daniel Bristot de Oliveira <bristot@...nel.org>
Cc:     Ingo Molnar <mingo@...hat.com>, Tom Zanussi <zanussi@...nel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Clark Williams <williams@...hat.com>,
        John Kacur <jkacur@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        linux-rt-users@...r.kernel.org, linux-trace-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V5 04/20] trace/osnoise: Use
 start/stop_per_cpu_kthreads() on osnoise_cpus_write()

On Mon, 25 Oct 2021 19:40:29 +0200
Daniel Bristot de Oliveira <bristot@...nel.org> wrote:

> When writing a new CPU mask via osnoise/cpus, if the tracer is running,
> the workload is restarted to follow the new cpumask. The restart is
> currently done using osnoise_workload_start/stop(), which disables the
> workload *and* the instrumentation. However, disabling the
> instrumentation is not necessary.
> 
> Calling start/stop_per_cpu_kthreads() is enough to apply the new
> osnoise/cpus config.
> 
> No functional change.

I nuked the "No functional change.". You can't have the changes of the
above and say there wasn't functional changes, as the first paragraph
explains the functional changes.

-- Steve

Powered by blists - more mailing lists