linux-kernel - Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39561c73-732e-bc38-e250-a0bdf51b09f9@linaro.org>
Date:   Tue, 26 Oct 2021 08:42:58 -0500
From:   Alex Elder <elder@...aro.org>
To:     Janusz Dziedzic <janusz.dziedzic@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     linux-soc@...r.kernel.org
Subject: Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS

On 10/25/21 11:31 AM, Janusz Dziedzic wrote:
> From: Alex Elder <elder@...aro.org>
> 
> Add a prompt to the "tristate" attribute in the Kconfig file in
> which QCOM_QMI_HELPERS is defined; I find it doesn't get selected
> without it.

This was a *long* time ago!
   https://lore.kernel.org/all/20180427140358.30839-1-elder@linaro.org/

The discussion that followed indicated that the thing that needs
QCOM_QMI_HELPERS should *select* it rather than *depend on it.

Will this not work for you?

					-Alex

> We need it in OpenWRT project, when using WiFi backports
> and build ath11k driver. While ath11k driver depends on
> QCOM_QMI_HELPERS we need way to enable this option in
> our kernel.
> 
> Signed-off-by: Alex Elder <elder@...aro.org>
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@...il.com>
> ---
>   drivers/soc/qcom/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index fe3c486ae32d..16fb8e286015 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -92,7 +92,7 @@ config QCOM_PDR_HELPERS
>   	select QCOM_QMI_HELPERS
>   
>   config QCOM_QMI_HELPERS
> -	tristate
> +	tristate "Qualcomm QMI Helpers"
>   	depends on NET
>   
>   config QCOM_RMTFS_MEM
>