linux-kernel - Re: [PATCH v7] tty: Fix the keyboard led light display problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 26 Oct 2021 23:41:17 +0800
From:   "常廉志" <changlianzhi@...ontech.com>
To:     "Greg KH" <gregkh@...uxfoundation.org>,
        "Andy Shevchenko" 
        <andriy.shevchenko@...ux.intel.com>
Cc:     "linux-kernel" <linux-kernel@...r.kernel.org>,
        "dmitry.torokhov" <dmitry.torokhov@...il.com>,
        "jirislaby" <jirislaby@...nel.org>,
        "282827961" <282827961@...com>
Subject: Re: [PATCH v7] tty: Fix the keyboard led light display problem

On Tue, Oct 26, 2021 at 05:23:35PM +0300, Andy Shevchenko wrote:
> On Tue, Oct 26, 2021 at 10:40:32AM +0800, lianzhi chang wrote:
> > Switching from the desktop environment to the tty environment,
> > the state of the keyboard led lights and the state of the keyboard
> > lock are inconsistent. This is because the attribute kb->kbdmode
> > of the tty bound in the desktop environment (xorg) is set to
>
> Xorg
>
> I think I already pointed that out.
>
> > VC_OFF, which causes the ledstate and kb->ledflagstate
> > values of the bound tty to always be 0, which causes the switch
> > from the desktop When to the tty environment, the LED light
> > status is inconsistent with the keyboard lock status.
>
> ...
>
> > +static void kbd_update_ledstate(struct input_dev *dev)
> > +{
> > + if (!!test_bit(LED_NUML, dev->led) !=
> > +     !!(ledstate & BIT(VC_NUMLOCK)))
> > + ledstate ^= BIT(VC_NUMLOCK);
> > + if (!!test_bit(LED_CAPSL, dev->led) !=
> > +     !!(ledstate & BIT(VC_CAPSLOCK)))
> > + ledstate ^= BIT(VC_CAPSLOCK);
> > + if (!!test_bit(LED_SCROLLL, dev->led) !=
> > +     !!(ledstate & BIT(VC_SCROLLOCK)))
> > + ledstate ^= BIT(VC_SCROLLOCK);
>
> This looks ugly.

I think it can be done like this:
 static void kbd_update_ledstate(struct input_dev *dev)
 {
    ledstate = (test_bit(LED_SCROLL,dev->led) ？1 ：0）
         | (test_bit(LED_NUML,dev->led) ？2 ：0）
         | (test_bit(LED_CAPSL,dev->led) ？3 ：0）
 }

If this change does not work, please reply to me. I have not 
understood the other content. It is too late today, I will continue tomorrow!

Thanks.
--
lianzhi chang