linux-kernel - Re: [PATCH] Revert "watchdog: iTCO_wdt: Account for rebooting on second timeout"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 Oct 2021 17:40:09 +0200
From:   Wim Van Sebroeck <wim@...ana.be>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Wim Van Sebroeck <wim@...ux-watchdog.org>,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jan Kiszka <jan.kiszka@...mens.com>,
        Mantas Mikulėnas <grawity@...il.com>,
        "Javier S . Pedro" <debbugs@...ispedro.com>
Subject: Re: [PATCH] Revert "watchdog: iTCO_wdt: Account for rebooting on
 second timeout"

Hi Guenter,

> On Thu, Oct 07, 2021 at 05:33:02PM -0700, Guenter Roeck wrote:
> > This reverts commit cb011044e34c ("watchdog: iTCO_wdt: Account for
> > rebooting on second timeout") and commit aec42642d91f ("watchdog: iTCO_wdt:
> > Fix detection of SMI-off case") since those patches cause a regression
> > on certain boards (https://bugzilla.kernel.org/show_bug.cgi?id=213809).
> > 
> > While this revert may result in some boards to only reset after twice
> > the configured timeout value, that is still better than a watchdog reset
> > after half the configured value.
> > 
> > Fixes: cb011044e34c ("watchdog: iTCO_wdt: Account for rebooting on second timeout")
> > Fixes: aec42642d91f ("watchdog: iTCO_wdt: Fix detection of SMI-off case")
> > Cc: Jan Kiszka <jan.kiszka@...mens.com>
> > Cc: Mantas Mikulėnas <grawity@...il.com>
> > Reported-by: Javier S. Pedro <debbugs@...ispedro.com>
> > Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> 
> Any chance you can send a pull request with this patch prior to the v5.15
> release ?

Will do it this evening.

Kind regards,
Wim.