lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 Oct 2021 09:56:53 +0800 From: Yafang Shao <laoar.shao@...il.com> To: Kees Cook <keescook@...omium.org> Cc: Andrew Morton <akpm@...ux-foundation.org>, Steven Rostedt <rostedt@...dmis.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>, Petr Mladek <pmladek@...e.com>, Peter Zijlstra <peterz@...radead.org>, Al Viro <viro@...iv.linux.org.uk>, Valentin Schneider <valentin.schneider@....com>, Qiang Zhang <qiang.zhang@...driver.com>, robdclark <robdclark@...omium.org>, christian <christian@...uner.io>, Dietmar Eggemann <dietmar.eggemann@....com>, Ingo Molnar <mingo@...hat.com>, Juri Lelli <juri.lelli@...hat.com>, Vincent Guittot <vincent.guittot@...aro.org>, David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>, Martin Lau <kafai@...com>, Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, john fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>, dennis.dalessandro@...nelisnetworks.com, mike.marciniszyn@...nelisnetworks.com, dledford@...hat.com, jgg@...pe.ca, linux-rdma@...r.kernel.org, netdev <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>, "linux-perf-use." <linux-perf-users@...r.kernel.org>, linux-fsdevel@...r.kernel.org, Linux MM <linux-mm@...ck.org>, LKML <linux-kernel@...r.kernel.org>, kernel test robot <oliver.sang@...el.com>, kbuild test robot <lkp@...el.com>, Andrii Nakryiko <andrii.nakryiko@...il.com> Subject: Re: [PATCH v6 07/12] samples/bpf/offwaketime_kern: make sched_switch tracepoint args adopt to comm size change On Tue, Oct 26, 2021 at 5:21 AM Kees Cook <keescook@...omium.org> wrote: > > On Mon, Oct 25, 2021 at 08:33:10AM +0000, Yafang Shao wrote: > > The sched:sched_switch tracepoint is derived from kernel, we should make > > its args compitable with the kernel. > > > > Signed-off-by: Yafang Shao <laoar.shao@...il.com> > > Cc: Mathieu Desnoyers <mathieu.desnoyers@...icios.com> > > Cc: Arnaldo Carvalho de Melo <arnaldo.melo@...il.com> > > Cc: Andrii Nakryiko <andrii.nakryiko@...il.com> > > Cc: Peter Zijlstra <peterz@...radead.org> > > Cc: Steven Rostedt <rostedt@...dmis.org> > > Cc: Al Viro <viro@...iv.linux.org.uk> > > Cc: Kees Cook <keescook@...omium.org> > > Cc: Petr Mladek <pmladek@...e.com> > > --- > > samples/bpf/offwaketime_kern.c | 4 ++-- > > Seems this should be merged with the prior bpf samples patch? > Sure > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/samples/bpf/offwaketime_kern.c b/samples/bpf/offwaketime_kern.c > > index 4866afd054da..eb4d94742e6b 100644 > > --- a/samples/bpf/offwaketime_kern.c > > +++ b/samples/bpf/offwaketime_kern.c > > @@ -113,11 +113,11 @@ static inline int update_counts(void *ctx, u32 pid, u64 delta) > > /* taken from /sys/kernel/debug/tracing/events/sched/sched_switch/format */ > > struct sched_switch_args { > > unsigned long long pad; > > - char prev_comm[16]; > > + char prev_comm[TASK_COMM_LEN]; > > int prev_pid; > > int prev_prio; > > long long prev_state; > > - char next_comm[16]; > > + char next_comm[TASK_COMM_LEN]; > > int next_pid; > > int next_prio; > > }; > > -- > > 2.17.1 > > > > -- > Kees Cook -- Thanks Yafang
Powered by blists - more mailing lists