linux-kernel - Re: [PATCH] kvm: Avoid shadowing a local in search

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YXgvTnhVWZ0gJdFs@google.com>
Date:   Tue, 26 Oct 2021 16:39:42 +0000
From:   Sean Christopherson <seanjc@...gle.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     Qian Cai <quic_qiancai@...cinc.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kvm: Avoid shadowing a local in search_memslots()

On Tue, Oct 26, 2021, Paolo Bonzini wrote:
> On 26/10/21 18:14, Qian Cai wrote:
> > > Maybe "pivot"?  Or just "tmp"?  I also vote to hoist the declaration out of the
> > > loop precisely to avoid potential shadows, and to also associate the variable
> > > with the "start" and "end" variables, e.g.
> > Actually, I am a bit more prefer to keep the declaration inside the loop
> > as it makes the declaration and assignment closer to make it easier to
> > understand the code. It should be relatively trivial to avoid potential
> > shadows in the future. It would be interesting to see what Paolo would say.
> 
> You both have good arguments, so whoever writes the patch wins. :)

LOL, KVM's version of Thunderdome.