lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 Oct 2021 18:52:39 +0200 From: "Rafael J. Wysocki" <rafael@...nel.org> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Heikki Krogerus <heikki.krogerus@...ux.intel.com>, ACPI Devel Maling List <linux-acpi@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "Rafael J. Wysocki" <rafael@...nel.org>, Sakari Ailus <sakari.ailus@...ux.intel.com>, YE Chengfeng <cyeaa@...nect.ust.hk> Subject: Re: [PATCH v1 1/1] device property: Drop redundant NULL checks On Tue, Oct 26, 2021 at 6:30 PM Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote: > > In cases when functions are called via fwnode operations, > we already know that this is software node we are dealing > with, hence no need to check if it's NULL, it can't be, > > Reported-by: YE Chengfeng <cyeaa@...nect.ust.hk> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com> or please let me know if I need to pick this up. > --- > drivers/base/swnode.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c > index c46f6a8e14d2..4debcea4fb12 100644 > --- a/drivers/base/swnode.c > +++ b/drivers/base/swnode.c > @@ -413,9 +413,6 @@ software_node_get_name(const struct fwnode_handle *fwnode) > { > const struct swnode *swnode = to_swnode(fwnode); > > - if (!swnode) > - return "(null)"; > - > return kobject_name(&swnode->kobj); > } > > @@ -507,9 +504,6 @@ software_node_get_reference_args(const struct fwnode_handle *fwnode, > int error; > int i; > > - if (!swnode) > - return -ENOENT; > - > prop = property_entry_get(swnode->node->properties, propname); > if (!prop) > return -ENOENT; > -- > 2.33.0 >
Powered by blists - more mailing lists