linux-kernel - Re: [PATCH v2] dt-bindings: net: qcom,ipa: IPA does support up to two iommus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <JNGL1R.U8OWUCOV58262@ixit.cz>
Date:   Tue, 26 Oct 2021 19:02:07 +0200
From:   David Heidelberg <david@...t.cz>
To:     Alex Elder <elder@...e.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Alex Elder <elder@...nel.org>, ~okias/devicetree@...ts.sr.ht,
        linux-arm-msm@...r.kernel.org, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: net: qcom,ipa: IPA does support up to two
 iommus

thanks, I'll try to work on my commit messages :)

David


On Tue, Oct 26 2021 at 11:47:46 -0500, Alex Elder <elder@...e.org> 
wrote:
> On 10/26/21 11:32 AM, David Heidelberg wrote:
>> Fix warnings as:
>> arch/arm/boot/dts/qcom-sdx55-mtp.dt.yaml: ipa@...0000: iommus: [[21, 
>> 1504, 0], [21, 1506, 0]] is too long
>> 	From schema: Documentation/devicetree/bindings/net/qcom,ipa.yaml
>> 
>> Signed-off-by: David Heidelberg <david@...t.cz>
> 
> Looks good to me.  I'm not sure why the minItems is required,
> unless it's to indicate that it must be at least 1 and can't
> be missing.  But iommus is also stated to be required elsewhere
> in the binding.
> 
> In the future, it's helpful to indicate the command you
> used to produce the warning in your commit message.  And
> furthermore, describing the problem (and not just including
> the error message) is even more helpful.
> 
> Reviewed-by: Alex Elder <elder@...aro.org>
> 
>> ---
>>   Documentation/devicetree/bindings/net/qcom,ipa.yaml | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml 
>> b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
>> index b8a0b392b24e..b86edf67ce62 100644
>> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
>> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
>> @@ -64,7 +64,8 @@ properties:
>>         - const: gsi
>>       iommus:
>> -    maxItems: 1
>> +    minItems: 1
>> +    maxItems: 2
>>       clocks:
>>       maxItems: 1
>> 
>