linux-kernel - Re: [PATCH] virtio-ring: fix DMA metadata flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACGkMEvV2HkXyv4RfB3pfmeaG8Nv4=XBG2Y1c+7mi0OnOUCWNA@mail.gmail.com>
Date:   Wed, 27 Oct 2021 10:32:45 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Vincent Whitchurch <vincent.whitchurch@...s.com>
Cc:     "Michael S. Tsirkin" <mst@...hat.com>, kernel@...s.com,
        virtualization <virtualization@...ts.linux-foundation.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] virtio-ring: fix DMA metadata flags

On Tue, Oct 26, 2021 at 9:31 PM Vincent Whitchurch
<vincent.whitchurch@...s.com> wrote:
>
> The flags are currently overwritten, leading to the wrong direction
> being passed to the DMA unmap functions.
>
> Fixes: 72b5e8958738aaa4 ("virtio-ring: store DMA metadata in desc_extra for split virtqueue")
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@...s.com>

Acked-by: Jason Wang <jasowang@...hat.com>

Thanks

> ---
>  drivers/virtio/virtio_ring.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index dd95dfd85e98..3035bb6f5458 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -576,7 +576,7 @@ static inline int virtqueue_add_split(struct virtqueue *_vq,
>         /* Last one doesn't continue. */
>         desc[prev].flags &= cpu_to_virtio16(_vq->vdev, ~VRING_DESC_F_NEXT);
>         if (!indirect && vq->use_dma_api)
> -               vq->split.desc_extra[prev & (vq->split.vring.num - 1)].flags =
> +               vq->split.desc_extra[prev & (vq->split.vring.num - 1)].flags &=
>                         ~VRING_DESC_F_NEXT;
>
>         if (indirect) {
> --
> 2.28.0
>