linux-kernel - Re: [PATCH] ACPI: glue: Use acpi_device_adr() in acpi_find_child

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YXmN7tnG6fddKhTJ@smile.fi.intel.com>
Date:   Wed, 27 Oct 2021 20:35:42 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Linux ACPI <linux-acpi@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>
Subject: Re: [PATCH] ACPI: glue: Use acpi_device_adr() in
 acpi_find_child_device()

On Wed, Oct 27, 2021 at 07:23:43PM +0200, Rafael J. Wysocki wrote:
> On Wed, Oct 27, 2021 at 7:17 PM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> > On Wed, Oct 27, 2021 at 06:59:06PM +0200, Rafael J. Wysocki wrote:

...

> See acpi_set_pnp_ids().
> 
> adev->pnp.bus_addres is the address value and
> adev->pnp.type.bus_address is a flag that is set to 1 when _ADR is
> valid.
> 
> > IIUC _ADR == 0 is a valid value and children may have it like this.
> 
> That's true.
> 
> > I believe this change will break the working things (first comes to my mind
> > is drivers/mfd/intel_quark_i2c_gpio.c).
> 
> I don't think so.

With your explanation I see where my logic is wrong. Thanks!

-- 
With Best Regards,
Andy Shevchenko