linux-kernel - Re: [PATCH] ACPI: APEI: mark apei_hest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 27 Oct 2021 20:37:20 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Christoph Hellwig <hch@....de>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>, James Morse <james.morse@....com>,
        Tony Luck <tony.luck@...el.com>,
        Borislav Petkov <bp@...en8.de>,
        Robert Moore <robert.moore@...el.com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" <devel@...ica.org>
Subject: Re: [PATCH] ACPI: APEI: mark apei_hest_parse

On Wed, Oct 27, 2021 at 8:54 AM Christoph Hellwig <hch@....de> wrote:
>
> apei_hest_parse is only used in hest.c, so mark it static.
>
> Signed-off-by: Christoph Hellwig <hch@....de>
> ---
>  drivers/acpi/apei/hest.c | 5 +++--
>  include/acpi/apei.h      | 3 ---
>  2 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c
> index 277f00b288d14..0edc1ed476737 100644
> --- a/drivers/acpi/apei/hest.c
> +++ b/drivers/acpi/apei/hest.c
> @@ -86,7 +86,9 @@ static int hest_esrc_len(struct acpi_hest_header *hest_hdr)
>         return len;
>  };
>
> -int apei_hest_parse(apei_hest_func_t func, void *data)
> +typedef int (*apei_hest_func_t)(struct acpi_hest_header *hest_hdr, void *data);
> +
> +static int apei_hest_parse(apei_hest_func_t func, void *data)
>  {
>         struct acpi_hest_header *hest_hdr;
>         int i, rc, len;
> @@ -121,7 +123,6 @@ int apei_hest_parse(apei_hest_func_t func, void *data)
>
>         return 0;
>  }
> -EXPORT_SYMBOL_GPL(apei_hest_parse);
>
>  /*
>   * Check if firmware advertises firmware first mode. We need FF bit to be set
> diff --git a/include/acpi/apei.h b/include/acpi/apei.h
> index 680f80960c3dc..ece0a8af2bae7 100644
> --- a/include/acpi/apei.h
> +++ b/include/acpi/apei.h
> @@ -37,9 +37,6 @@ void __init acpi_hest_init(void);
>  static inline void acpi_hest_init(void) { return; }
>  #endif
>
> -typedef int (*apei_hest_func_t)(struct acpi_hest_header *hest_hdr, void *data);
> -int apei_hest_parse(apei_hest_func_t func, void *data);
> -
>  int erst_write(const struct cper_record_header *record);
>  ssize_t erst_get_record_count(void);
>  int erst_get_record_id_begin(int *pos);
> --

Applied as 5.16 material, thanks!