linux-kernel - Re: [PATCH v3 0/2] Disable mass storage endpoints during disconnect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211027201438.GB1326060@rowland.harvard.edu>
Date:   Wed, 27 Oct 2021 16:14:38 -0400
From:   Alan Stern <stern@...land.harvard.edu>
To:     Wesley Cheng <quic_wcheng@...cinc.com>
Cc:     balbi@...nel.org, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        jackp@...eaurora.org
Subject: Re: [PATCH v3 0/2] Disable mass storage endpoints during disconnect

On Wed, Oct 27, 2021 at 01:10:05PM -0700, Wesley Cheng wrote:
> Changes in v3:
>  - Modify statement for usb_ep_enable().
>  - Add explicit statement mentioning that APIs can be called in atomic context.
> 
> Changes in v2:
>  - Revised comments for usb_ep_disable() as it should be safe to be
>    executed in atomic contexts as well.  Other FDs are currently
>    calling ep disable during the disconnect event as well.
> 
> This series calls the usb_ep_disable() API directly from fsg_disable()
> as there is a possibility that UDCs that support runtime PM may
> already be in a suspended state, leading to HW access while resources
> are disabled.
> 
> Wesley Cheng (2):
>   usb: gadget: udc: core: Revise comments for USB ep enable/disable
>   usb: gadget: f_mass_storage: Disable eps during disconnect
> 
>  drivers/usb/gadget/function/f_mass_storage.c | 10 ++++++++++
>  drivers/usb/gadget/udc/core.c                |  4 ++--
>  2 files changed, 12 insertions(+), 2 deletions(-)

For both patches:

Acked-by: Alan Stern <stern@...land.harvard.edu>