linux-kernel - Re: [PATCH 1/3] pinctrl: Add driver for Sunplus SP7021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ed37bf9-d698-2a03-60e7-9b357e3abfb4@infradead.org>
Date:   Wed, 27 Oct 2021 15:12:04 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Wells Lu <wellslutw@...il.com>, linus.walleij@...aro.org,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        robh+dt@...nel.org, devicetree@...r.kernel.org
Cc:     qinjian@...lus1.com, dvorkin@...bo.com,
        Wells Lu <wells.lu@...plus.com>
Subject: Re: [PATCH 1/3] pinctrl: Add driver for Sunplus SP7021

Hi--

On 10/27/21 1:55 AM, Wells Lu wrote:
> diff --git a/drivers/pinctrl/sunplus/Kconfig b/drivers/pinctrl/sunplus/Kconfig
> new file mode 100644
> index 0000000..93b5ccf
> --- /dev/null
> +++ b/drivers/pinctrl/sunplus/Kconfig
> @@ -0,0 +1,32 @@
> +# SPDX-License-Identifier: GPL-2.0
> +#
> +# Sunplus Pin control driver configuration
> +#
> +
> +config PINCTRL_SPPCTL
> +	bool "Sunplus SP7021 pinmux and gpio driver"

Preferably                              GPIO

> +	depends on SOC_SP7021
> +	select PINMUX
> +	select GENERIC_PINCTRL_GROUPS
> +	select CONFIG_GENERIC_PINMUX_FUNCTIONS

	Drop   CONFIG_

> +	select PINCONF
> +	select GENERIC_PINCONF
> +	select OF_GPIO

Probably
	depends on OF && HAS_IOMEM
Otherwise how do you know that it's safe to do
	select OF_GPIO
?


> +	select GPIOLIB
> +	select GPIO_SYSFS
> +	select GENERIC_IRQ_CHIP
> +	select GPIOLIB_IRQCHIP
> +	help
> +	  Say Y here to support Sunplus SP7021 pinmux controller.
> +	  The driveer is selected automatically by platform.

	      driver

> +	  This driver requires the pinctrl framework.
> +	  GPIO is provided by the same driver.
> +
> +config PINCTRL_SPPCTL_DEBUG
> +	bool "Sunplus pinmux specific debug"
> +	depends on SOC_SP7021 && DEBUG_PINCTRL
> +	help
> +	  Say Y if you need to debug Sunplus pinmux driver in-depth.
> +	  Pin control driver will output more messages if you enable
> +	  this item. This function is dependent on DEBUG_PINCTRL. It
> +	  should be enabled first.


thanks.
-- 
~Randy