linux-kernel - Re: [PATCH 1/3] tracing/histogram: Document hist trigger variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211028071319.44e3e885352866713dd08046@kernel.org>
Date:   Thu, 28 Oct 2021 07:13:19 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Kalesh Singh <kaleshsingh@...gle.com>
Cc:     surenb@...gle.com, hridya@...gle.com, namhyung@...nel.org,
        kernel-team@...roid.com, rostedt@...dmis.org, mhiramat@...nel.org,
        Ingo Molnar <mingo@...hat.com>, Shuah Khan <shuah@...nel.org>,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH 1/3] tracing/histogram: Document hist trigger variables

On Wed, 27 Oct 2021 13:59:08 -0700
Kalesh Singh <kaleshsingh@...gle.com> wrote:

> Update the tracefs README to describe how hist trigger variables
> can be created.
> 
> Signed-off-by: Kalesh Singh <kaleshsingh@...gle.com>

This looks good to me.

Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

Thank you!

> ---
>  kernel/trace/trace.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index bc677cd64224..c41b3786401d 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -5628,6 +5628,7 @@ static const char readme_msg[] =
>  #ifdef CONFIG_HIST_TRIGGERS
>  	"      hist trigger\t- If set, event hits are aggregated into a hash table\n"
>  	"\t    Format: hist:keys=<field1[,field2,...]>\n"
> +	"\t            [:<var1>=<field|var_ref|numeric_literal>[,<var2>=...]]\n"
>  	"\t            [:values=<field1[,field2,...]>]\n"
>  	"\t            [:sort=<field1[,field2,...]>]\n"
>  	"\t            [:size=#entries]\n"
> @@ -5639,6 +5640,16 @@ static const char readme_msg[] =
>  	"\t            common_timestamp - to record current timestamp\n"
>  	"\t            common_cpu - to record the CPU the event happened on\n"
>  	"\n"
> +	"\t    A hist trigger variable can be:\n"
> +	"\t        - a reference to a field e.g. x=current_timestamp,\n"
> +	"\t        - a reference to another variable e.g. y=$x,\n"
> +	"\t        - a numeric literal: e.g. ms_per_sec=1000,\n"
> +	"\t        - an arithmetic expression: e.g. time_secs=current_timestamp/1000\n"
> +	"\n"
> +	"\t    hist trigger aritmethic expressions support addition(+), subtraction(-),\n"
> +	"\t    multiplication(*) and division(/) operators. An operand can be either a\n"
> +	"\t    variable reference, field or numeric literal.\n"
> +	"\n"
>  	"\t    When a matching event is hit, an entry is added to a hash\n"
>  	"\t    table using the key(s) and value(s) named, and the value of a\n"
>  	"\t    sum called 'hitcount' is incremented.  Keys and values\n"
> -- 
> 2.33.0.1079.g6e70778dc9-goog
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>