linux-kernel - Re: [PATCH v2 18/45] riscv: Use do_kernel_power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Oct 2021 16:09:07 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     digetx@...il.com
CC:     thierry.reding@...il.com, jonathanh@...dia.com,
        lee.jones@...aro.org, rafael@...nel.org, broonie@...nel.org,
        akpm@...ux-foundation.org, linux@...ck-us.net,
        linux@...linux.org.uk, daniel.lezcano@...aro.org,
        andriy.shevchenko@...ux.intel.com, ulf.hansson@...aro.org,
        catalin.marinas@....com, will@...nel.org, guoren@...nel.org,
        geert@...ux-m68k.org, gerg@...ux-m68k.org, funaho@...ai.org,
        tsbogend@...ha.franken.de, nickhu@...estech.com,
        green.hu@...il.com, deanbo422@...il.com,
        James.Bottomley@...senPartnership.com, deller@....de,
        mpe@...erman.id.au, benh@...nel.crashing.org, paulus@...ba.org,
        Paul Walmsley <paul.walmsley@...ive.com>,
        aou@...s.berkeley.edu, ysato@...rs.sourceforge.jp, dalias@...c.org,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
        dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
        boris.ostrovsky@...cle.com, jgross@...e.com,
        sstabellini@...nel.org, lenb@...nel.org, ssantosh@...nel.org,
        krzysztof.kozlowski@...onical.com, linus.walleij@...aro.org,
        wens@...e.org, j.neuschaefer@....net, tony@...mide.com,
        lgirdwood@...il.com, p.zabel@...gutronix.de, vz@...ia.com,
        avifishman70@...il.com, tmaimon77@...il.com, tali.perry1@...il.com,
        venture@...gle.com, yuenn@...gle.com, benjaminfair@...gle.com,
        pavel@....cz, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-csky@...r.kernel.org,
        linux-ia64@...r.kernel.org, linux-m68k@...ts.linux-m68k.org,
        linux-mips@...r.kernel.org, linux-parisc@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, linux-riscv@...ts.infradead.org,
        linux-sh@...r.kernel.org, xen-devel@...ts.xenproject.org,
        linux-acpi@...r.kernel.org, linux-omap@...r.kernel.org,
        openbmc@...ts.ozlabs.org, linux-tegra@...r.kernel.org,
        linux-pm@...r.kernel.org
Subject:     Re: [PATCH v2 18/45] riscv: Use do_kernel_power_off()

On Wed, 27 Oct 2021 14:16:48 PDT (-0700), digetx@...il.com wrote:
> Kernel now supports chained power-off handlers. Use do_kernel_power_off()
> that invokes chained power-off handlers. It also invokes legacy
> pm_power_off() for now, which will be removed once all drivers will
> be converted to the new power-off API.
>
> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> ---
>  arch/riscv/kernel/reset.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/arch/riscv/kernel/reset.c b/arch/riscv/kernel/reset.c
> index 9c842c41684a..912288572226 100644
> --- a/arch/riscv/kernel/reset.c
> +++ b/arch/riscv/kernel/reset.c
> @@ -23,16 +23,12 @@ void machine_restart(char *cmd)
>
>  void machine_halt(void)
>  {
> -	if (pm_power_off != NULL)
> -		pm_power_off();
> -	else
> -		default_power_off();
> +	do_kernel_power_off();
> +	default_power_off();
>  }
>
>  void machine_power_off(void)
>  {
> -	if (pm_power_off != NULL)
> -		pm_power_off();
> -	else
> -		default_power_off();
> +	do_kernel_power_off();
> +	default_power_off();
>  }

Acked-by: Palmer Dabbelt <palmer@...belt.com>