linux-kernel - Re: [PATCH v1 1/1] delay: Replace kernel.h with the necessary inclusions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202110280737.hD5HfYcX-lkp@intel.com>
Date:   Thu, 28 Oct 2021 07:15:13 +0800
From:   kernel test robot <lkp@...el.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>
Subject: Re: [PATCH v1 1/1] delay: Replace kernel.h with the necessary
 inclusions

Hi Andy,

I love your patch! Yet something to improve:

[auto build test ERROR on linux/master]
[also build test ERROR on hnaz-mm/master linus/master v5.15-rc7 next-20211027]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/delay-Replace-kernel-h-with-the-necessary-inclusions/20211027-230458
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2f111a6fd5b5297b4e92f53798ca086f7c7d33a4
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/fd321f3d5b18ccab48b82ee4099ae79961067fdc
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Andy-Shevchenko/delay-Replace-kernel-h-with-the-necessary-inclusions/20211027-230458
        git checkout fd321f3d5b18ccab48b82ee4099ae79961067fdc
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/media/dvb-frontends/cxd2880/cxd2880_common.c: In function 'cxd2880_convert2s_complement':
>> drivers/media/dvb-frontends/cxd2880/cxd2880_common.c:18:30: error: implicit declaration of function 'GENMASK' [-Werror=implicit-function-declaration]
      18 |                 return (int)(GENMASK(31, bitlen) | value);
         |                              ^~~~~~~
   cc1: all warnings being treated as errors


vim +/GENMASK +18 drivers/media/dvb-frontends/cxd2880/cxd2880_common.c

1a3ef038d09e66 Yasunari Takiguchi 2018-01-18  11  
1a3ef038d09e66 Yasunari Takiguchi 2018-01-18  12  int cxd2880_convert2s_complement(u32 value, u32 bitlen)
1a3ef038d09e66 Yasunari Takiguchi 2018-01-18  13  {
1a3ef038d09e66 Yasunari Takiguchi 2018-01-18  14  	if (!bitlen || bitlen >= 32)
1a3ef038d09e66 Yasunari Takiguchi 2018-01-18  15  		return (int)value;
1a3ef038d09e66 Yasunari Takiguchi 2018-01-18  16  
1a3ef038d09e66 Yasunari Takiguchi 2018-01-18  17  	if (value & (u32)(1 << (bitlen - 1)))
1a3ef038d09e66 Yasunari Takiguchi 2018-01-18 @18  		return (int)(GENMASK(31, bitlen) | value);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (61666 bytes)