linux-kernel - Re: [PATCH v2] f2fs: compress: disallow disabling compress on non-empty compressed file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3be80c98-f637-c5a5-929f-1ddc1994c7bc@kernel.org>
Date:   Wed, 27 Oct 2021 12:26:01 +0800
From:   Chao Yu <chao@...nel.org>
To:     Hyeong-Jun Kim <hj514.kim@...sung.com>,
        Jaegeuk Kim <jaegeuk@...nel.org>
Cc:     Sungjong Seo <sj1557.seo@...sung.com>,
        linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] f2fs: compress: disallow disabling compress on
 non-empty compressed file

On 2021/10/27 12:16, Hyeong-Jun Kim wrote:
> Compresse file and normal file has differ in i_addr addressing,
> specifically addrs per inode/block. So, we will face data loss, if we
> disable the compression flag on non-empty files. Therefore we should
> disallow not only enabling but disabling the compression flag on
> non-empty files.
> 
> ---
> v2:
>   - check F2FS_HAS_BLOCKS() instead of i_size
> 
> Fixes: 4c8ff7095bef ("f2fs: support data compression")
> Signed-off-by: Sungjong Seo <sj1557.seo@...sung.com>
> Signed-off-by: Hyeong-Jun Kim <hj514.kim@...sung.com>

Reviewed-by: Chao Yu <chao@...nel.org>

Thanks,