linux-kernel - [PATCH] nds32: ftrace: fix pointer comparison warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211027055554.19372-1-rdunlap@infradead.org>
Date:   Tue, 26 Oct 2021 22:55:54 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     linux-kernel@...r.kernel.org
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        kernel test robot <lkp@...el.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Zong Li <zong@...estech.com>, Nick Hu <nickhu@...estech.com>,
        Vincent Chen <deanbo422@...il.com>
Subject: [PATCH] nds32: ftrace: fix pointer comparison warning

GCC 11.1.0 for nds32 (nds32le if it matters) complains:

../arch/nds32/kernel/ftrace.c: In function '_mcount':
../arch/nds32/kernel/ftrace.c:24:35: error: comparison of distinct pointer types lacks a cast [-Werror]
   24 |         if (ftrace_trace_function != ftrace_stub)
      |                                   ^~

Cast the second function (pointer) to (void *) to avoid the warning.

Fixes: a18082575c66 ("nds32/ftrace: Support static function tracer")
Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Reported-by: kernel test robot <lkp@...el.com>
To: Greentime Hu <green.hu@...il.com>
Cc: Steven Rostedt (VMware) <rostedt@...dmis.org>
Cc: Masami Hiramatsu <mhiramat@...nel.org>
Cc: Zong Li <zong@...estech.com>
Cc: Nick Hu <nickhu@...estech.com>
Cc: Vincent Chen <deanbo422@...il.com>
---
 arch/nds32/kernel/ftrace.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20211026.orig/arch/nds32/kernel/ftrace.c
+++ linux-next-20211026/arch/nds32/kernel/ftrace.c
@@ -21,7 +21,7 @@ noinline void _mcount(unsigned long pare
 
 	unsigned long ip = (unsigned long)__builtin_return_address(0);
 
-	if (ftrace_trace_function != ftrace_stub)
+	if (ftrace_trace_function != (void *)ftrace_stub)
 		ftrace_trace_function(ip - MCOUNT_INSN_SIZE, parent_ip,
 				      NULL, NULL);