linux-kernel - Re: [PATCH] sound: ua101: fix division by zero at probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h7ddzx9xf.wl-tiwai@suse.de>
Date:   Wed, 27 Oct 2021 08:23:56 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Johan Hovold <johan@...nel.org>
Cc:     Clemens Ladisch <clemens@...isch.de>,
        Takashi Iwai <tiwai@...e.com>,
        Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] sound: ua101: fix division by zero at probe

On Tue, 26 Oct 2021 11:54:01 +0200,
Johan Hovold wrote:
> 
> Add the missing endpoint max-packet sanity check to probe() to avoid
> division by zero in alloc_stream_buffers() in case a malicious device
> has broken descriptors (or when doing descriptor fuzz testing).
> 
> Note that USB core will reject URBs submitted for endpoints with zero
> wMaxPacketSize but that drivers doing packet-size calculations still
> need to handle this (cf. commit 2548288b4fb0 ("USB: Fix: Don't skip
> endpoint descriptors with maxpacket=0")).
> 
> Fixes: 63978ab3e3e9 ("sound: add Edirol UA-101 support")
> Cc: stable@...r.kernel.org      # 2.6.34
> Signed-off-by: Johan Hovold <johan@...nel.org>

Thanks, applied.


Takashi