linux-kernel - Re: gpu: drm_fb_cma_helper.c:46: undefined reference to `drm_gem_fb_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a3v9mb8RH7ER=iF2SAizv-Sb=hTWzpuQzL050ToR02h+Q@mail.gmail.com>
Date:   Wed, 27 Oct 2021 08:50:39 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Naresh Kamboju <naresh.kamboju@...aro.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        open list <linux-kernel@...r.kernel.org>,
        Linux-Next Mailing List <linux-next@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Andrey Konovalov <andreyknvl@...il.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: gpu: drm_fb_cma_helper.c:46: undefined reference to `drm_gem_fb_get_obj'

On Wed, Oct 27, 2021 at 8:26 AM Randy Dunlap <rdunlap@...radead.org> wrote:
> On 10/26/21 11:19 PM, Arnd Bergmann wrote:
> > On Wed, Oct 27, 2021 at 2:58 AM Randy Dunlap <rdunlap@...radead.org> wrote:

> > This trivial change makes it all build:
> >
> > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> > index c08860db2520..699f434ce813 100644
> > --- a/drivers/gpu/drm/Kconfig
> > +++ b/drivers/gpu/drm/Kconfig
> > @@ -218,7 +218,7 @@ config DRM_GEM_CMA_HELPER
> >            Choose this if you need the GEM CMA helper functions
> >
> >   config

> > -       bool
> > +       tristate
> >          depends on DRM
> >          select DRM_GEM_CMA_HELPER
> >          help
> >
> > but this needs some more testing to make sure it doesn't add
> > any other regressions.
> >
> > Interestingly, I never hit the problem in randconfig testing since
> > there is always some '=y' driver that selects DRM_KMS_HELPER.
>
> Thomas had posted a patch that also fixes the problem.
> Somehow I missed seeing that the first time around.

Ah right, I missed that as well. That patch seems reasonable
to me, but I think we may want both of them in this case, as
it does not address DRM_GEM_CMA_HELPER being set to =y
when it is only used from modules.

       Arnd