linux-kernel - Re: [PATCH] HID: wacom: Make use of the helper function devm_add_action_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2110271014090.12554@cbobk.fhfr.pm>
Date:   Wed, 27 Oct 2021 10:15:02 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Jason Gerecke <killertofu@...il.com>
cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Ping Cheng <pinglinux@...il.com>,
        Benjamin Tissoires <benjamin.tissoires@...il.com>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Linux Input <linux-input@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Aaron Skomra <skomra@...il.com>,
        "Dickens, Joshua" <joshua.dickens@...om.com>,
        Cai Huoqing <caihuoqing@...du.com>
Subject: Re: [PATCH] HID: wacom: Make use of the helper function
 devm_add_action_or_reset()

On Tue, 26 Oct 2021, Jason Gerecke wrote:

> Following up on this. I took a second look at the shared struct, and 
> believe that things should work fine during initialization and 
> steady-state. There are, however, opportunities for e.g. one 
> device/thread to be removed and set e.g. `shared->touch = NULL` while a 
> second device/thread is attempting to send an event out of that device. 
> This is going to be very rare and only on disconnect, which is probably 
> why we've never received reports of real-world issues.
> 
> This shared issue is present with or without the changes by Cai and
> myself. I would ask that these two patches be merged 

Now applied. Thanks,

-- 
Jiri Kosina
SUSE Labs