linux-kernel - Re: [PATCH] platform/x86: remove duplicate include in barco-p50-gpio.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 27 Oct 2021 10:19:54 +0200
From:   Peter Korsgaard <peter@...sgaard.com>
To:     cgel.zte@...il.com
Cc:     santoshkumar.yadav@...co.com, peter.korsgaard@...co.com,
        hdegoede@...hat.com, markgross@...nel.org,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        ran jianping <ran.jianping@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] platform/x86: remove duplicate include in barco-p50-gpio.c

>>>>> "cgel" == cgel zte <cgel.zte@...il.com> writes:

 > From: ran jianping <ran.jianping@....com.cn>
 > 'linux/io.h' included in 'drivers/platform/x86/barco-p50-gpio.c'
 >  is duplicated.It is also included on the 17 line.

 > Reported-by: Zeal Robot <zealci@....com.cn>
 > Signed-off-by: ran jianping <ran.jianping@....com.cn>
 > ---
 >  drivers/platform/x86/barco-p50-gpio.c | 1 -
 >  1 file changed, 1 deletion(-)

 > diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c
 > index f5c72e33f9ae..bb8ed8e95225 100644
 > --- a/drivers/platform/x86/barco-p50-gpio.c
 > +++ b/drivers/platform/x86/barco-p50-gpio.c
 > @@ -14,7 +14,6 @@
 >  #include <linux/delay.h>
 >  #include <linux/dmi.h>
 >  #include <linux/err.h>
 > -#include <linux/io.h>

It probably makes more sense to drop the include from line 17 to keep
alphabetical ordering, but otherwise it looks good to.

With that fixed:

Acked-by: Peter Korsgaard <peter@...sgaard.com>

-- 
Bye, Peter Korsgaard