linux-kernel - RE: [PATCH v7 2/4] iio: adc: Add Xilinx AMS driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY5PR02MB6916298122D8F4BDEFF67D0FA9859@BY5PR02MB6916.namprd02.prod.outlook.com>
Date:   Wed, 27 Oct 2021 09:04:51 +0000
From:   Anand Ashok Dumbre <ANANDASH@...inx.com>
To:     Lars-Peter Clausen <lars@...afoo.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jic23@...nel.org" <jic23@...nel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        git <git@...inx.com>, Michal Simek <michals@...inx.com>,
        "pmeerw@...erw.net" <pmeerw@...erw.net>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
CC:     Manish Narani <MNARANI@...inx.com>
Subject: RE: [PATCH v7 2/4] iio: adc: Add Xilinx AMS driver

Hi Lars,

Thanks for the review.

> On 10/19/21 5:20 PM, Anand Ashok Dumbre wrote:
> > [...]
> > +#define AMS_CHAN_TEMP(_scan_index, _addr) { \
> > +	.type = IIO_TEMP, \
> > +	.indexed = 1, \
> > +	.address = (_addr), \
> > +	.info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \
> > +		BIT(IIO_CHAN_INFO_SCALE) | \
> > +		BIT(IIO_CHAN_INFO_OFFSET), \
> > +	.info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ), \
> There is no handling of IIO_CHAN_INFO_SAMP_FREQ in read_raw(). Reading
> the sampling_frequency attribute always returns -EINVAL.
Correct. I will remove it.

> > +	.event_spec = ams_temp_events, \
> > +	.scan_index = _scan_index, \
> > +	.num_event_specs = ARRAY_SIZE(ams_temp_events), \ }
> > +
> > +#define AMS_CHAN_VOLTAGE(_scan_index, _addr, _alarm) { \
> > +	.type = IIO_VOLTAGE, \
> > +	.indexed = 1, \
> > +	.address = (_addr), \
> > +	.info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \
> > +		BIT(IIO_CHAN_INFO_SCALE), \
> > +	.info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ), \
> > +	.event_spec = (_alarm) ? ams_voltage_events : NULL, \
> > +	.scan_index = _scan_index, \
> > +	.num_event_specs = (_alarm) ? ARRAY_SIZE(ams_voltage_events) :
> 0, \
> > +}

Also, for some reason, I haven’t received rest of your comments in the mail, but I see them on patchwork.
I am not sure how I can respond to those comments.

Thanks,
Anand